feat(cli): Windows (win32-x64) prebuilt app bundle - #192
Draft
hilash wants to merge 1 commit into
Draft
Conversation
Extends the zero-install bundle path to Windows (x64): - win32-x64 AppBundleKey in cabinetai + app-side release-manifest types/keys - generate-release-manifest emits a win32-x64 bundle entry - release.yml publish-app-bundles builds on windows-latest (shell: bash so the bash packaging script runs under Git Bash) - run.ts resolves the bundled node as node.exe on Windows Not yet validated on a real Windows host — see PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows prebuilt app bundle (
win32-x64)Follow-up to #65, which shipped the zero-install
npx cabinetai runprebuilt-bundle path for macOS/Linux and left Windows on the source +npm installfallback. This adds the Windows (x64) bundle.Changes
win32-x64added toAppBundleKey(cabinetai + app-side) and to the key lists ingenerate-release-manifest.mjs/src/lib/system/release-manifest.ts.getAppBundleKey()mapswin32+x64→win32-x64.release.ymlpublish-app-bundlesbuilds onwindows-latest(withshell: bashso the bash packaging script runs under Git Bash).run.tsresolves the bundled node asnode.exeon Windows.The node-pty staging for
win32prebuilds already landed with #65 (prepare-electron-package.mjs, keyed offtargetPlatform).I built and verified the macOS/Linux path end-to-end (bundle boots, app + daemon healthy, Chrome DevTools render), but I can't produce or run a Windows bundle here. Before merging, please validate on Windows x64:
publish-app-bundlesmatrix (or a test release tag) and confirm thewindows-latestjob builds and uploadscabinet-app-win32-x64-vX.tgz+.sha256. Watch for:tarbehavior under Git Bash, andnpm run electron:prepstagingnode-pty/prebuilds/win32-x64.npx cabinetai run, confirm it downloads the win32 bundle (not the source fallback), bootsserver.jsviabin\node.exe, and the app + daemon serve. node-pty terminals in particular exercise the native binding.Leaving as draft until someone confirms the above on Windows.