Add rapid equilibrium reactions for CSTR#324
Open
AntoniaBerger wants to merge 19 commits into
Open
Conversation
Contributor
|
if you write the keyword to close the issue right in front of the corresponding issue, it will automatically be closed when the PR is merged. I.e. writing "fixes" instead of "resolves therefore" in the PR description .. maybe "resolves" also works |
AntoniaBerger
changed the title
jbreue16
reviewed
Nov 28, 2024
AntoniaBerger
changed the title
AntoniaBerger
force-pushed
the
feature/rapid_equilibrium_reactions
branch
from
1765bfd to
6a4367e
Compare
- to residiumImpl - jacobian - jacderivative
little changes
AntoniaBerger
force-pushed
the
feature/rapid_equilibrium_reactions
branch
from
52023f9 to
85df024
Compare
AntoniaBerger
changed the title
…d of iteration simple example works without consistent initalisation fix conserved moities calculation
AntoniaBerger
force-pushed
the
feature/rapid_equilibrium_reactions
branch
from
3a3ed1d to
1d033f5
Compare
AntoniaBerger
force-pushed
the
feature/rapid_equilibrium_reactions
branch
from
1d033f5 to
6ddcd08
Compare
This way we are more flexible to use conserved moities in for different units.
AntoniaBerger
force-pushed
the
feature/rapid_equilibrium_reactions
branch
from
c666401 to
7be73be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
This PR will add the feature to set reactions into a rapid equilibrium in liquid phase for the CSTR
Workflow:
More information about the algorithm are available under the forum post about reactions in rapid equilibrium