Skip to content

Include Doxygen build#89

Open
schmoelder wants to merge 3 commits into
masterfrom
feature/add_doxygen
Open

Include Doxygen build#89
schmoelder wants to merge 3 commits into
masterfrom
feature/add_doxygen

Conversation

@schmoelder

Copy link
Copy Markdown
Contributor

Fixes #88

I can locally build doxygen with doxygen doc/cadet.doxyfile. However, sphinx currently produces an error due to an open issue upstream when using @todo in the documentation.

(!) Unabridged API: unexpected kind 'page' (IGNORED)
[...]
File "~/miniconda3/envs/sphinx/lib/python3.9/site-packages/exhale/graph.py", line 516, in toConsole
    kind=utils._use_color(self.kind, fmt_spec[self.kind], sys.stderr),
KeyError: 'page'

@schmoelder schmoelder force-pushed the feature/add_doxygen branch from 57b2217 to ea14384 Compare June 18, 2024 12:38
@schmoelder schmoelder force-pushed the feature/add_doxygen branch from ea14384 to 5f04b26 Compare June 18, 2024 12:44
@schmoelder schmoelder requested a review from jbreue16 June 18, 2024 12:44
@schmoelder

Copy link
Copy Markdown
Contributor Author

This should work now. It's not pretty but that's more of a long term project, I'd say. Please verify that it builds locally!

@jbreue16 jbreue16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doxygen to the environment

Documentation build works, but running the command
./ ./build/ command does not work
to build for all branches, releases doesnt

@schmoelder schmoelder force-pushed the feature/add_doxygen branch from 5f04b26 to 508f29f Compare June 18, 2024 13:31
@schmoelder

Copy link
Copy Markdown
Contributor Author

please try again.

@schmoelder schmoelder requested a review from jbreue16 June 18, 2024 19:06

@jbreue16 jbreue16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry, i accidentally built a different branch first.
For this PR, the build all still doesnt work, ive attached the error log
doc_build_error.txt

@schmoelder

Copy link
Copy Markdown
Contributor Author

Did you use the updated command?

sphinx-multiversion ./ ./build/ -D 'exhale_args.containmentFolder=${sourcedir}/api'

@jbreue16

Copy link
Copy Markdown
Contributor

yes

@schmoelder

Copy link
Copy Markdown
Contributor Author

Hmm, it does work for me and I got the command from the sphinx-multiversion documentation. Maybe it's a Windows issue? @ronald-jaepel could you try to reproduce this?

@ronald-jaepel

ronald-jaepel commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

sphinx-build -b html . build works

sphinx-multiversion ./ ./build/ -D 'exhale_args.containmentFolder=${sourcedir}/api' produces the same error that Jan got:

The given `containmentFolder` [C:\Users\ronal\Documents\CADET\doc\api] must be a *SUBDIRECTORY* of [C:\Users\ronal\AppData\Local\Temp\tmpq3qlnnkv\17599e50de92cdc95c89a2ce98c529c18cee471e\doc].
Traceback (most recent call last):

@ronald-jaepel

Copy link
Copy Markdown
Contributor

For Windows cmd the command needs to be without single quotes, so
sphinx-multiversion ./ ./build/ -D exhale_args.containmentFolder=${sourcedir}/api works.

@schmoelder schmoelder force-pushed the feature/add_doxygen branch from 508f29f to 2cea74a Compare June 20, 2024 09:49
@schmoelder

schmoelder commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

Thanks! Unfortunately, it doesn't run on Linux without the quotes so I added a comment in the README.

@schmoelder schmoelder marked this pull request as ready for review June 20, 2024 10:06

@jbreue16 jbreue16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just came to my attention that the files in src directory are not included, this needs to be fixed

@schmoelder

Copy link
Copy Markdown
Contributor Author

Sorry to ask, but what are the next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

Include doxygen documentation in sphinx

3 participants