Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Fix some issues in lz4 support#22

Open
john-cado wants to merge 4 commits intomainfrom
jlugton/lz4-cleanup
Open

Fix some issues in lz4 support#22
john-cado wants to merge 4 commits intomainfrom
jlugton/lz4-cleanup

Conversation

@john-cado
Copy link
Contributor

Ran into some issues with lz4 support where we attempt to reopen the file for writing as a zip later in the process. Suggest reviewing commits separately since this includes some initial tidying up:

  • Move fields from LinuxSystem to constants/locals, making LinuxSystem and WindowsSystem __init__s identical
  • Dedup init methods
  • Open output file once and have all methods write to it instead of repeatedly opening for appending

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant