fix: defer drop-position setState to avoid mutation during layout pass#59
Merged
caduandrade merged 1 commit intoMar 18, 2026
Merged
Conversation
Owner
|
Thank you for fixing that! |
Owner
|
Version 1.16.2 released. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When dragging a tab over a split-view pane,
onWillAcceptWithDetailson theDragTargetinsideContentWrapperBase'sLayoutBuilderfires synchronouslyduring Flutter's layout phase. The listener callback immediately calls
setState(),which marks a sibling pane's RenderObject as needing layout while the current
LayoutBuilderis still inperformLayout. Flutter asserts in debug mode:Reproducible with two panes in split view — drag any tab a couple times (fast): sometimes it fires.
Fix
Wrap the
setStateinSchedulerBinding.instance.addPostFrameCallbackin bothDockingItemWidgetStateandDockingTabsWidgetState. This defers the stateupdate until after the current frame's layout and paint are complete.