explore: resolve a solution by content_signature in solutions and curate - #124
Open
cafzal wants to merge 1 commit into
Open
explore: resolve a solution by content_signature in solutions and curate#124cafzal wants to merge 1 commit into
cafzal wants to merge 1 commit into
Conversation
certify's per_pick names the certified plan that beats a dominated finalist by content_signature, and its next_steps tells you to go curate that point in its place. Neither action accepted a signature, so the prescribed move meant listing the whole exact overlay and scanning by eye — which overflows the response cap at a few hundred points and puts the answer back on disk. That is the exact round trip per-pick verdicts were added to remove: the certificate produced the answer and the surface made you go find it again. Surfaced by driving shift_coverage_staffing end to end: both curated picks came back dominated, and re-curating meant a spill file to map signature -> id. curate already keyed remove/rename on content_signature — pinning was the odd one out, so this is the action agreeing with itself, not a new convention. Resolution is scoped to the run source/scenario selects, since the same plan carries the same signature in the heuristic run and the exact overlay; an unresolved signature returns the surface's standard error naming which run it searched, because the wrong source is the likely mistake. Engine helper beside get_solution; certify's next_steps and the solution_interpreter 'Reading the Certificate' section now teach the one-call route. Tests: 910 passed / 2 skipped, incl. a round trip that runs the certificate's own routing verbatim and re-certifies to 2/2 optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
certify'sper_picknames the certified plan that beats a dominated finalist bycontent_signature, and its ownnext_stepssays to go curate that point in its place. Neitherexplore solutionsnorexplore curateaccepted a signature — both wantedsolution_id.So the prescribed move meant listing the whole exact overlay and scanning by eye. On
shift_coverage_staffingthat listing is 80,746 chars for 253 points: it overflows the response cap and spills to a file, putting the answer back on disk. That is the exact round trip per-pick verdicts were added to remove — the certificate produced the answer, and the surface made you go find it again.Surfaced by driving the example end to end on current main: both curated picks came back dominated, and re-curating required the spill file to map signature → id.
Why this shape
curatealready keyedremoveandrenameoncontent_signature. Pinning was the odd one out, so this is the action agreeing with itself rather than a new convention.feedbackis the other precedent — it has taken "solution_id OR content_signature" all along.Resolution is scoped to the run
source/scenarioselects: the same plan carries the same signature in the heuristic run and the exact overlay, so the caller says which one it means. An unresolved signature returns the surface's standarderrorand names the run it searched, because passing the wrongsourceis the likely mistake.Layering follows the existing split: engine helper (
explorer.resolve_signature) besideget_solution, routing prose incertify'snext_steps, read-side teaching insolution_interpreter→ Reading the Certificate, contract language in the tool docstring and the architecture tools table.Tests
910 passed / 2 skipped. The one that matters is
test_certify_routing_round_trips— it executes the certificate's own instructions verbatim (certify → curate the named signature fromsource="exact"→ unpin the beaten one → re-certify) and asserts the second certificate reports every remaining finalistoptimal. A per-pick verdict the user can't act on without reading files off disk is the defect being closed, so the test closes the loop rather than checking the parameter is accepted.