Skip to content

Work in progress#337

Draft
ninjeeter wants to merge 11 commits intomainfrom
AP-Android-Refactor-1
Draft

Work in progress#337
ninjeeter wants to merge 11 commits intomainfrom
AP-Android-Refactor-1

Conversation

@ninjeeter
Copy link
Contributor

  • Need to explicitly set numbered instructions to just add the tools to system PATH to avoid absolute paths in commands.
  • Reword Frida section.
  • Write Troubleshoot page.

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 73.5%, saving 90.9 KB.

Filename Before After Improvement Visual comparison
src/_images/android_studio_standard.png 57.4 KB 14.3 KB 75.1% View diff
src/_images/sdk_manager.png 49.8 KB 13.2 KB 73.6% View diff
src/_images/android_studio_sdk_tools.png 16.5 KB 5.4 KB 67.3% View diff

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 7.7%, saving 2.5 KB.

Filename Before After Improvement Visual comparison
src/_images/android_studio_standard.png 14.3 KB 13.2 KB 7.2% View diff
src/_images/sdk_manager.png 13.2 KB 12.2 KB 7.5% View diff
src/_images/android_studio_sdk_tools.png 5.4 KB 4.9 KB 9.6% View diff

…plicit comparison or type conversion is required @typescript-eslint/strict-boolean-expressions
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 5.9%, saving 1.1 KB.

Filename Before After Improvement Visual comparison
src/_images/android_studio_standard.png 13.2 KB 12.6 KB 5.2% View diff
src/_images/android_studio_sdk_tools.png 4.9 KB 4.5 KB 7.5% View diff

1 image did not require optimisation.

… old. To ensure accurate Baseline data, please update: `npm i baseline-browser-mapping@latest -D`
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 7.7%, saving 2.5 KB.

Filename Before After Improvement Visual comparison
src/_images/android_studio_standard.png 14.3 KB 13.2 KB 7.2% View diff
src/_images/sdk_manager.png 13.2 KB 12.2 KB 7.5% View diff
src/_images/android_studio_sdk_tools.png 5.4 KB 4.9 KB 9.6% View diff

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 5.9%, saving 1.1 KB.

Filename Before After Improvement Visual comparison
src/_images/android_studio_standard.png 13.2 KB 12.6 KB 5.2% View diff
src/_images/android_studio_sdk_tools.png 4.9 KB 4.5 KB 7.5% View diff

1 image did not require optimisation.

link: "/app/tutorials/android_browser_virtual",
},
{
text: "Adding Caido's CA Certificate to the System Partition",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be before "Proxying MObile Chrome Browser Traffic"? I feel like you want to do the entire setup first, before starting to proxy stuff.

link: "/app/tutorials/android_virtual_device"
},
{
text: "Proxying Mobile Chrome Browser Traffic",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename this to "Proxying Browser Traffic", we're already in the "Android" section so no need to mention Mobile.

link: "/app/tutorials/android_physical_device"
},
{
text: "Proxying Mobile Chrome Browser Traffic",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment regarding the title.

]
},
{
text: "Modifying an Android Application: Virtual & Physical Devices",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd simplify this title, it's a bit long.
Something like "Modifying Your First APK"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why these files are marked as new?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants