Repository navigation
fix: check the manifest format version before the JSON Schema - #71
Merged
Merged
Conversation
NAM-022 says a consumer reads `format` before it applies the manifest JSON Schema, and rejects an unsupported value with a statement that the format version is not supported. NAM-021 says a manifest that is not a JSON object, or has no `format` member, is invalid. validate_manifest now checks these three cases first and stops with one failure, so a format 2 manifest reports "format 2 is not supported", not a JSON Schema failure. The format check after the JSON Schema is gone, because it could no longer fail. Closes #57
dfkunstler
force-pushed
the
fix/manifest-format-first
branch
from
November 17, 2026 02:31
384233c to
d95bb97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57.
scripts/manifest.pynow checks the format version before the manifest JSON Schema (NAM-022). A manifest that is nota JSON object, has no
formatmember (NAM-021), or holds an unsupportedformatfails with one failure, and noother check runs. A format 2 manifest now reports
format 2 is not supported (supported: 1), not a JSON Schema failure.test_nam_003_05_*(which asserted the old JSON Schema failure) with NAM-021.01, NAM-022.01, andNAM-022.02 tests, plus non-integer
formatvalues (true,"1",1.5,null,[1])..agents/summary/workflows.md.Independent of #70:
names.schema.jsondeclaresformatthe same way (const: 1) in 0.7.0 and 0.8.0.Benchmarks
No runtime code changed.
hatch run python scripts/bench_serialization.py, SP 800-53 rev5 catalog, Python 3.14.8,pydantic 2.14.2, median of 7 (ms, GC on / GC off).