chore(deps-dev): bump eslint from 9.39.2 to 10.1.0 in /frontend#206
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
chore(deps-dev): bump eslint from 9.39.2 to 10.1.0 in /frontend#206dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.1.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.1.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
area:frontend
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
5430
to
5432
| "eslint": "bin/eslint.js" | ||
| }, | ||
| "engines": { |
There was a problem hiding this comment.
The new engine requirement for eslint@10.x is ^20.19.0 || ^22.13.0 || >=24, dropping support for Node.js 18 entirely and requiring Node.js 20.19.0+ (not just any Node 20). If any CI runner, Docker image, or developer machine is on Node.js 18 or Node.js 20 < 20.19.0, the lint script will break.
It's worth verifying the Node.js version in .nvmrc, .node-version, CI workflow files, or engines field in package.json is compatible with this new requirement before merging.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/package-lock.json
Line: 5430-5432
Comment:
**ESLint v10 raises the Node.js minimum version**
The new engine requirement for `eslint@10.x` is `^20.19.0 || ^22.13.0 || >=24`, dropping support for Node.js 18 entirely and requiring Node.js 20.19.0+ (not just any Node 20). If any CI runner, Docker image, or developer machine is on Node.js 18 or Node.js 20 < 20.19.0, the `lint` script will break.
It's worth verifying the Node.js version in `.nvmrc`, `.node-version`, CI workflow files, or `engines` field in `package.json` is compatible with this new requirement before merging.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eslint from 9.39.2 to 10.1.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
8351ec710.1.03270bc1Build: changelog update for 10.1.0a9f9ccechore: update dependency eslint-plugin-unicorn to ^63.0.0 (#20584)1f42bd7chore: updateprettierto 3.8.1 (#20651)c0a6f4achore: update dependency@eslint/jsonto ^1.2.0 (#20652)cc43f79chore: update dependency c8 to v11 (#20650)2ce4635chore: update dependency@eslint/jsonto v1 (#20649)f0406eechore: update dependency markdownlint-cli2 to ^0.21.0 (#20646)dbb4c95chore: remove trunk (#20478)ff4382bfeat: apply fix forno-varinTSModuleBlock(#20638)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Greptile Summary
This PR is a Dependabot-generated major version upgrade of
eslintfrom9.39.2to10.1.0in the frontend. ESLint v10 removes legacy.eslintrcsupport, bumps several internal packages to new majors (eslint-scopev9,espreev11,eslint-visitor-keysv5,minimatchv10), and raises the Node.js minimum to^20.19.0 || ^22.13.0 || >=24.Key findings:
@eslint/jsleft at^9.32.0:@eslint/jsis a companion package toeslintversioned in lockstep.eslint.config.jsimports it directly (import js from \"@eslint/js\") and usesjs.configs.recommended. Leaving it on v9 whileeslintruns v10 is an unsupported combination that could silently produce incorrect lint results or break the lint run outright. This package should also be bumped to^10.1.0.npm run lint.@eslint/eslintrcfrom the transitive dependency tree is expected since the project already uses flat config (eslint.config.js), so that specific breaking change does not affect this repo.Confidence Score: 3/5
Not safe to merge as-is —
@eslint/jsmust be co-bumped to v10 to matcheslint@10.xbefore this upgrade is complete.There is a clear P1 defect:
@eslint/jsis left at^9.32.0whileeslintmoves to^10.1.0. The flat config ineslint.config.jsimports@eslint/jsdirectly and usesjs.configs.recommended, so this version mismatch will either break linting or produce undefined behaviour. The PR is genuinely incomplete.frontend/package.json—@eslint/jsversion must be bumped to^10.1.0alongsideeslint.Important Files Changed
eslintfrom^9.32.0to^10.1.0, but fails to bump the companion package@eslint/jsfrom^9.32.0— a version mismatch that can break the flat config setup.@eslint/eslintrc,chalk,lodash.merge,js-yaml,import-freshand bumpseslint-scope,eslint-visitor-keys,espree,acorn, andminimatchto new major versions.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["eslint@10.1.0\n(bumped ✅)"] -->|"requires"| B["@eslint/js@10.x\n(NOT bumped ❌ still at ^9.32.0)"] A -->|"requires"| C["eslint-scope@9.1.2"] A -->|"requires"| D["eslint-visitor-keys@5.0.1"] A -->|"requires"| E["espree@11.2.0"] A -->|"requires"| F["minimatch@10.2.5"] A -->|"removed"| G["@eslint/eslintrc\n(legacy .eslintrc support dropped)"] A -->|"removed"| H["chalk / lodash.merge / js-yaml"] B -->|"used in"| I["eslint.config.js\nimport js from '@eslint/js'\njs.configs.recommended"] style B fill:#f96,stroke:#c00 style G fill:#ccc,stroke:#999 style H fill:#ccc,stroke:#999Comments Outside Diff (1)
frontend/package.json, line 78 (link)@eslint/jsnot bumped to match ESLint v10@eslint/jsis still pinned to"^9.32.0"whileeslinthas been bumped to"^10.1.0". These two packages are developed and versioned in sync within the same monorepo —@eslint/js@9.xis designed to accompanyeslint@9.x.eslint.config.jsdirectly imports this package:Running
eslint@10.xwith@eslint/js@9.xis an untested and unsupported combination. Rule definitions, config structures, or internal types that@eslint/jsexports may differ between major versions, potentially causing linting failures or silently incorrect rule application.This PR should also bump
@eslint/jsto^10.1.0:Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore(deps-dev): bump eslint from 9.39.2..." | Re-trigger Greptile