Fix flaky testCreateTableIndexWithWhere position lookup#1085
Merged
Conversation
The test was hardcoding queries[2] to find the CREATE UNIQUE INDEX output. The dryrun message buffer now contains additional phinxlog setup messages before the create-index call, so the position drifted and the test failed locally. Look the query up by its expected prefix instead, which makes the test robust to ordering changes around it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test was hardcoding
$queries[2]to pluck the CREATE UNIQUE INDEX statement out of the dry-run message buffer. The buffer now contains a handful of phinxlog setup messages before the create-index call:So the test was failing locally with the assertion message:
Found while reducing the PHPStan baseline in #1083; the failure is pre-existing and reproducible on master.
Fix
Walk the message buffer and pick the matching query rather than indexing by position. The two assertions on the index DDL contents are unchanged.