Enable ESS calculation in metric calc#761
Conversation
…t/climakitae into feature/metric-calc-ess
|
@claalmve and @neilSchroeder looking for both technical and methods review - I want to make sure I haven't changed the underlying methodology for the effective sample size, just extended it to run over datasets with more dimensions. |
neilSchroeder
left a comment
There was a problem hiding this comment.
A few small things
claalmve
left a comment
There was a problem hiding this comment.
This PR looks great! Tested the notebook, everything looks well. I only left one comment about my confusion on the docstring, otherwise no notes!
|
|
||
| References | ||
| ---------- | ||
| Zwiers, F. W., and H. von Storch, 1995: Taking Serial Correlation into Account in Tests of the Mean. J. Climate, 8, 336–351, https://doi.org/10.1175/1520-0442(1995)008<0336:TSCIAI>2.0.CO;2. |
| - block_size (int, optional): Block size in years. Default: 1 | ||
| - goodness_of_fit_test (bool, optional): Perform KS test. Default: True | ||
| - alpha (float, optional): Significance level, between 0-1, for confidence intervals. Default UNSET | ||
| - alpha (float, optional): Alpha value (1 - significance level) for confidence intervals. Default UNSET |
There was a problem hiding this comment.
How come it's 1 - significance level and not just significance level?
There was a problem hiding this comment.
We could use confidence level as a variable rather than alpha, I just thought of alpha first. Alpha's the variable for the probability of being in the tails of the distribution, outside of the confidence interval.
There was a problem hiding this comment.
Updated the alpha variable description since I've been getting different feedback on the significance level part - leaving that out.
Summary of changes and related issue
Link to corresponding Jira ticket(s)
AE-1412
Testing
How to Test
Here's a notebook set up with several tests to check that the ESS test runs, or doesn't, as expected:
ess_test.ipynb
Also verify that unit tests are working in CI.
Documentation
Code Quality
_Review Process
Administrative Reminders