Updated write_tmy_file()

[vdmachuca]

Updated variable list and removed setting the order of "scenario" column.

Summary of changes and related issue

Updated write_tmy_file() to be compatible to recent changes to TMY scripts/notebooks, which affected the variable names and column structure.

Link to corresponding Jira ticket(s)

Testing

• Unit tests written for new/modified code (goal: 80% coverage)
  • All public functions have unit tests
  • Functions that must produce specific values have unit tests
• Verified that notebooks utilizing affected functions still work
• Appropriate manual testing completed
• Advanced Testing label added to PR if this PR makes major changes to the codebase

How to Test

Run the shock XMY methodology notebook and use write_tmy_file() to export results.

Documentation

• Complex code includes comments explaining logic
• Function documentation created (docstrings)

Code Quality

• Follows PEP8 naming and style conventions
• Helper functions prefixed with underscore _
• Linting completed and all issues resolved
• Does not replicate existing functionality
• Aligns with general coding standards of existing codebase
• Code generalized for multiple uses (unless too complex/time-intensive)

Review Process

• PR review instructions provided:
  • Type of review requested (scientific/technical/debugging)
  • Level of review detail needed

Administrative Reminders

• Jira ticket moved to "Review" when PR created
• Jira ticket will be moved to "Done" when complete
• PR branch will be deleted after merge

[vicford]

Okay, I believe the problem arises with what we want the column headers to be vs. what the data columns themselves are. The reason csv breaks is that the columns list is being used for both the headers and to subset the underlying dataframe by column name.

This is seen more so in the .tmy data format -- the data columns are what the WRF variables actually are, but the header function resets what the header labels are.

If we want the csv to have cleaner looking header labels, create a separate csv_header function to handle. Alternatively and likely easier: the .tmy format is actually a .csv file with a fancy header, and most importantly the filename extension is specifically .tmy not .csv. We can feed two birds with one scone by reusing the .tmy code with the only difference being what the filename extension is. In other words, I'm suggesting that if a user requests a .csv format, they actually get back a .tmy file with the filename extension of .csv

[vicford]

Please drop if not needed

[vicford]

Revert this change. These are the data columns. The dataframe headers labels are reset in the _tmy_header() function.

[vicford]

Revert this change. This is attempting to rename the data columns to the desired header labels.