Andi/filtering#92
Open
andi-halim wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Implemented Filtering for Farm Production History Graph (ProductionGraph.js), Top Items Graph (TopItemsGraph.js), and Recent Harvests Graph (RecentHarvestsGraph.js). The filtering takes the inputted dates and filters them by the month interval specified.
Additionally, I implemented an extra feature on changing the filter's header when dates are applied to the filter selection. It changes from "Date Filters" to "[start date] to [end date]".
(Andi's Last PR thanks for all the good times!)
How to Review
Related PRs
Next steps
Additional Options was commented out from the file as it does not work unless implemented. Currently, it will freeze if an additional option is selected and the filter is applied. Once implemented, it will work again.
VictoryGraphs are still buggy with 3 or less X values (categories/dates).
Filter Menu should save/cache the Applied Filtered Dates so that a user can pick up where they left off if they choose to filter again.
Filtering for the other two graphs have not been implemented (HarvestLogs and GAP Certification).
Not very related to this PR but related to the page. There's a bug with the See More button under the Harvest Logs graph that affects the rest of the page too.
Stretch Feature: Could create a Top # Items as a filter in the Top Items Graph.
Screenshots
Design Status
CC: @phoebeli23