Camera connection - use substream instead of mainstream - #11
Merged
Conversation
…ry, this increases stability while processing in live-mode
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the sample connection string to use substream, instead of the mainstream. I recently discovered that this exists, and upon testing, increases stability of the live feed processing service significantly (haven't seen it go down yet).
There are some known issues regarding live-mode's stability, where after a period of time, the service will crash with errors similar to what's described here.
Using substream instead of mainstream reduces the bandwidth of the stream, increasing stability, while maintaining clear enough images for the core computer vision logic to recognize baby features over time.
An upcoming PR largely overhauling the design replaces this line, and a note about the difference between
mainstreamandsubstreamideally would be preserved in (or after) that PR so that users know about the now preferred substream channel.