Repository navigation
Conversation
… fetching it again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kept small on purpose so it's easy to review.
When a torrent is ready,
get_statushas already fetched the full record with/seedbox/list?ids=and_handle_torrent_infohas checked that every file is at 100%. The retrieval thread was then started without that list, so_process_and_downloadcalled_fetch_file_list, which asks the same endpoint again. That second call runs inside the thread's genericexcept, without the flood and transient error handling the status path has, so a rate limit or a hiccup there sets the phase to error for a torrent that finished fine.This passes the files already in hand into the thread.
_process_and_downloadalready took an optionalfilesargument. The new test starts the thread from a ready status and checks it uses the given list and never calls_fetch_file_list.Separately,
download_urlreturns aBytesIO, so a whole file sits in memory. AllDebrid, TorBox and Real-Debrid do the same, so I left that for a streaming variant of the shared helper instead of fixing it for one client here.Ruff and basedpyright are clean and
tests/prowlarrpasses.The one red check is the existing clock-dependent test
test_a_queued_torrent_asks_for_a_grace_once, which fails on any runner that booted recently. It is fixed in #1426 and is not caused by this change.