Repository navigation
Conversation
…'s error, not as an unknown source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kept small on purpose so it's easy to review. This is the same kind of small fix as the ones in #1429 to #1432, so see the question in #1429 about separate PRs versus combined. I'm sending them separately until I hear otherwise.
In
search_source_releasestheexcept ValueErrorcomes before the branch that handles the operational errors, andValueErroris in that tuple. AValueErrorfrombuild_release_search_planorsource.search()is therefore reported asUnknown source: <name>instead of<name>: <message>. The onlyValueErrormeant for that branch is the oneget_sourceraises for a name that isn't registered, so that call now has its owntryand the rest goes back to the operational errors branch.The failure test already covered
OSErrorandRuntimeError, so I addedValueErrorto it, and that case fails on currentmain. Ruff, basedpyright andtests/corepass.The one red check is the existing clock-dependent test
test_a_queued_torrent_asks_for_a_grace_once, which fails on any runner that booted recently. It is fixed in #1426 and is not caused by this change.