PR to remove Handlesbars (#12), add debounce, clear subpart array, and minor tweaks.#15
Open
jogoodma wants to merge 12 commits intocalipho-sib:masterfrom
Open
PR to remove Handlesbars (#12), add debounce, clear subpart array, and minor tweaks.#15jogoodma wants to merge 12 commits intocalipho-sib:masterfrom
jogoodma wants to merge 12 commits intocalipho-sib:masterfrom
Conversation
…o help with performance on large sequences.
Removed Handlebar references. Conflicts: build/viewer.js
Added a debounce to the regex search. Regex searches on a long sequence is an expensive computation. The search was being fired on each keystroke (keyup event) which created a noticeable stutter/delay in the UI. To alleviate this, a debounce function was added to the handler so that it is called after the user has stopped typing and not after each keystroke.
This change fires an event that will clear the subpart selection array when a user removes all text from the sequence search box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues: