docs(examples): fix DHL argparse help copy-pasted from meta-learning - #85
Open
SAY-5 wants to merge 1 commit into
Open
docs(examples): fix DHL argparse help copy-pasted from meta-learning#85SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…ning The --gm_op/--na_op/--fo_op flags in examples/data_hyper_cleaning/data_hyper_cleaning.py described omniglot/miniimagenet/tieredImagenet and convnet/resnet, which are meta-learning datasets and architectures unrelated to data hyper-cleaning. Reported in callous-youth#24. Replace the help strings with the operator names actually accepted for each flag (Gradient Mapping / Numerical Approximation / First-Order) and point readers at boat_torch/{gm_ol,na_ol,fo_ol}/ for the authoritative list. Closes callous-youth#24 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
--gm_op,--na_op, and--fo_opflags inexamples/data_hyper_cleaning/data_hyper_cleaning.py(lines 58-75) advertisedomniglot or miniimagenet or tieredImagenetandconvnet for 4 convs or resnet for Residual blocks. Those values belong to the meta-learning example: data hyper-cleaning does not consume datasets or backbones, it composes GM/NA/FO operators.The result was that a new user running
python data_hyper_cleaning.py --helpto learn the legal values for these flags was directed to incorrect names. Reported in #24.This PR replaces the help strings with the operator names actually accepted by each flag, derived from the modules under
boat_torch/gm_ol/,boat_torch/na_ol/, andboat_torch/fo_ol/, and points readers at those directories for the authoritative list. No runtime behaviour changes.Closes #24
Types of Changes
Pre-Submission Checklist
black(only the touched hunks; pre-existing whitespace nits in unrelated lines were left untouched to keep the diff scoped).