Repository navigation
chore(scripts): bounded audit of bookkeeping edits forced on feat and fix PRs #2413
Copy link
Copy link
Closed
Labels
Description
Activity
Bounded audit: ten most recent feat/fix commits touching
scripts/Commits (newest first),
git log --no-mergesonorigin/main(heade7d97f7dfe), filtered to subjects starting withfeat/fixand touchingscripts/:# Commit Subject 1 d11c8cf9d6feat: support standalone Maestro clearState command (#2366) 2 3f022b0730fix(gates): stop an eager-closure approval from turning main red on merge (#2375) 3 7bea29d61efix: repair main after the managed-allocation move landed under stale PRs (#2328) 4 ebdaa7617efeat: delegate reviewed managed automation (#2312) 5 96727a0b42fix(apple-runner): never compare an unavailable toolchain probe; name the mismatching cache keys (#2306) 6 fa06c8c6e9fix(daemon): fence managed readiness behind runtime admission (#2280) 7 5bb3ea3b2afeat(ios): productionize Simulator AX snapshot bridge (#2277) 8 172ee149cffeat(screenshot): add --crop-on to crop captures to a selector frame (#2276) 9 658f822c40fix: encode the mcp subcommand in server.json package arguments (#2275) 10 e882cf9723feat(runtime): add managed-local ownership and the exact-only managed runtime (#2258) Per-file classification
# Commit scripts/fileClassification 1 d11c8cf fuzz/validation-arbitraries-maestro.tsindependent evidence — new fuzz coverage for the clearStatecommand shape1 d11c8cf maestro-conformance/build-manifest.mjsapproved exception row — generator's NOTESmap for the new authored corpus flow1 d11c8cf maestro-conformance/corpus/authored/clear-state.yamlapproved exception row — pinned corpus fixture 1 d11c8cf maestro-conformance/corpus/manifest.jsonapproved exception row — generated manifest entry paired with the build-manifest.mjsNOTES row above (generator + checked-in output, not a redundant check)1 d11c8cf fixtures/layer1-parser.jsonapproved exception row — pinned upstream parser fixture 2 3f022b0 __tests__/committed-source-tree.tsindependent evidence — new headCommithelper backing the merge-base-is-head fix2 3f022b0 __tests__/eager-closure-budgets.test.tsindependent evidence — coverage for the new staleApprovalRowsrule2 3f022b0 __tests__/eager-closure-budgets.tsindependent evidence — genuine mechanism fix (merge-base-vs-head bug), not bookkeeping 3 7bea29d __tests__/eager-closure-budgets.tsapproved exception row — stale APPROVED_OVER_CEILINGrow removed exactly as the rule prescribes4 ebdaa76 layering/package-boundaries.test.tsapproved exception row — independently reviewed export-snapshot surface (established) 5 96727a0 write-xcuitest-cache-metadata.mjsindependent evidence — production CI script logic fix (fail-closed toolchain probe) 6 fa06c8c layering/architecture-ownership.tsapproved exception row — same archetype as the package-export snapshot: architecture-ownership.test.tsasserts the façade's actual named exports against this hand-declared list, so it is an independently reviewed surface, not a restatement of anything else in the PR7 5bb3ea3 __tests__/fixtures/size-report-npm-pack.jsonindependent evidence — fixture data for new test cases in the same PR 7 5bb3ea3 __tests__/size-report-package.test.tsindependent evidence — new assertions for assertPublishPackageContents's newrequireSnapshotBridgebehavior7 5bb3ea3 check-package.tsindependent evidence — separate install path ( installIntoCleanConsumer) exercising the same invariantsize-report-install.mjsexercises on its own (benchmark) install path; distinct call sites, not a restatement7 5bb3ea3 ios-snapshot-benchmark/size-install.test.tsindependent evidence — new coverage for assertInstalledSnapshotBridge7 5bb3ea3 layering/package-boundaries.test.tsapproved exception row — export-snapshot surface (established) 7 5bb3ea3 layering/platform-package-policy.test.tsapproved exception row — same hand-declared-surface archetype as architecture-ownership, applied to the new snapshot-sourcesubpath7 5bb3ea3 layering/platform-package-policy.tsapproved exception row — declares the new snapshot-sourcesubpath the policy test above checks7 5bb3ea3 size-report-install.mjsindependent evidence — post-install-directory check; distinct failure mode from the packed-tarball check below (catches install-time/publishing divergence, not packaging-config divergence) 7 5bb3ea3 size-report-package.mjsindependent evidence — packed-tarball-listing check ( assertSnapshotBridgeAssets), distinct from the post-install check above8 172ee14 integration-progress-model.tsapproved exception row — new named exemption row ( screenshotCropOn) with owner + reason, same pattern asAPPROVED_OVER_CEILING8 172ee14 layering/package-boundaries.test.tsapproved exception row — export-snapshot surface (established) 9 658f822 sync-mcp-metadata.mjsindependent evidence — production sync-script logic fix (adds the missing mcppositional argument)10 e882cf9 layering/package-boundaries.test.tsapproved exception row — export-snapshot surface (established) Result
No file edit across the ten commits classifies as duplicate bookkeeping. Every
scripts/edit is either:- independent evidence (a real behavior/test change backing the PR's own fix or feature), or
- an approved exception row (a hand-maintained, independently-checked declaration — merge-base-relative budget rows, the package/façade export-surface snapshots, or a named test-exclusion row with owner and reason).
No removal is proposed. Per the issue's bounded-audit acceptance criteria, closing with no implementation.
Audit complete: the ten-commit classification table is posted above and found no duplicate bookkeeping — every scripts/ edit in feat/fix PRs is independent evidence or an approved exception row. Closing with no implementation, as the issue specified. Part of #2409 (child 8: forecast 0, confirmed).
Child 8 of #2409.
Purpose
Find out whether any bookkeeping under
scripts/still forces edits on ordinary feature and fix PRs, and remove only what replays as a saved file without weakening independent evidence. Bounded: close with no implementation if nothing qualifies.Baseline
Measured on
mainate7d97f7dfe, recent 456 code commits:scripts/; 8% touchscripts/layering/. Refactor commits: 67% and 61%. The layering churn is the migration's own cost and fell from 35 to 6 per 100 commits.scripts/with the most edits:scripts/layering/package-boundaries.test.ts6,scripts/__tests__/eager-closure-budgets.ts5,scripts/maestro-conformance/build-manifest.mjs4,scripts/maestro-conformance/corpus/manifest.json4,scripts/__tests__/test-file-size-ratchet.test.ts4.package-boundaries.test.ts:55is an independently reviewed surface by design; Maestro fixtures are pinned upstream artifacts. Replaying the removal of every such edit over the recent 186 feat+fix commits moves the median files per commit from 8 to 8.Required work
scripts/. For eachscripts/file edited, classify the edit: independent evidence (keep), approved exception row (keep), or duplicate bookkeeping that restates something the same PR already declares elsewhere.Acceptance
scripts/edit is posted on this issue.Non-goals