You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ios): physical-device install lost devicectl hints; delete the dead install/uninstall/push paths #2785
#1758 (66cca1a) moved physical-device install to packages/platform-apple/src/deployment/runtime.ts:137-148. That code checks devicectl with the local assertAppleToolSuccess (:214-224) and never calls resolveIosDevicectlHint (core/devicectl.ts:365). Since then, physical install failures have not shown the Developer Mode, DDI and pairing hints that #1527 and #2690 added. Other devicectl paths still attach them (deployment/runtime.ts:81/266, core/physical-device-coredevice.ts:483, core/perf.ts:1095).
The old implementations are now dead:
installApp, uninstallApp and assertAppInstallationSupported in packages/platform-apple/src/core/physical-device-control.ts:45-130 have no callers.
pushIosNotification (core/app-device-io.ts:42-61) is test-only. deployment/runtime.ts:176 replaced it.
Line references are at 01328de411.
Required behavior
Physical install and uninstall in deployment/runtime.ts attach the same hint that resolveIosDevicectlHint produces for other devicectl failures. Route the call through runIosDevicectl, or call the resolver on failure. Keep the typed details.
Delete the dead functions listed above, their tests, and the declaration at test/integration/command-coverage/declarations.ts:512.
Keep physical-device-facade.ts and the physical-device-apps functions. They are live package exports that three daemon modules use.
Completion conditions
A unit test covers a devicectl install failure whose stderr shows Developer Mode is disabled. It asserts that the hint appears in the normalized error.
pnpm check:production-exports and pnpm check:fallow are green. Move baseline entries; do not regenerate them.
Activity
fix(ios): keep devicectl hints on physical install and delete the dea…