Skip to content

Remove interaction readiness result forwarding left after the readiness-wait removal #3607

Closed

Description

@thymikee

Purpose

#3599 removes the replay target-readiness wait, which was the only producer of an interaction readiness result ({ polls, waitedMs, end }). Two consumers still forward that field, and their tests still build the old shape. Delete them so no code describes a field that can no longer exist.

Blocked by: #3599 (merge first; these sites are unreachable only after it lands).

Required change

  • packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts: drop the 'readiness' in result copy into responseData.
  • packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts: drop 'readiness' from SAFE_CAUSE_DETAIL_KEYS.
  • Tests: in interaction-touch-response.test.ts, remove the readiness-shaped selectorResult fixture and the two readiness assertions, keeping the prior-warning assertion. In session-replay-runtime-failure-response.test.ts, remove "a replay divergence carries the readiness evidence of an exhausted target wait".

Done when

  • git grep -n -w readiness -- packages/daemon/src/execution/interaction packages/replay-port/src/daemon-port returns no interaction-result or replay-cause hits.
  • pnpm check:affected --base origin/main --run passes.
  • No behavior change: nothing produces the field after feat(interaction)!: remove target-readiness waits #3599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions