Skip to content

fix: secure Limrun dependency packaging - #1464

Closed
thymikee wants to merge 1 commit into
mainfrom
agent/fix-limrun-dependency-security
Closed

thymikee wants to merge 1 commit into
mainfrom
agent/fix-limrun-dependency-security

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

  • ship the patched Limrun dependency tree with Undici 7.28.0 so npm consumers no longer resolve the vulnerable 7.24.7 pin
  • replace Limrun's shell-interpolated adb connect path with argument-separated execution and keep agent-device on its shared execution helper
  • add prepack/tooling dependency policy enforcement and GitHub dependency review for new vulnerable dependency changes

The latest Limrun release still pins Undici 7.24.7, and dependency overrides are root-only. Bundling the reviewed, patched Limrun tree ensures the safe resolution reaches downstream installs.

This touches 10 files and expands from the Limrun Android provider into package security and CI enforcement. No CLI or wire contract changes.

Validation

  • packaged tarball contains @limrun/api 0.24.5, Undici 7.28.0, and the patched execFile call
  • security policy tests pass, including vulnerable Undici and shell-interpolation regression cases
  • full unit + subprocess-stub suite passes with --maxWorkers=4; smoke suite passes
  • formatting, typecheck, lint, build, layering, Fallow, dependency policy, Node integration, provider scenarios, and replay provenance passed
  • full default-concurrency runs hit existing host-contention timeouts; every timed-out scenario passed in isolation
  • SkillGym external runners were DNS-blocked before assertions

Residual risk: no live Limrun Android device was available to validate tunnel allocation and adb connect, so this PR is draft.

@github-actions

github-actions Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-28 15:18 UTC

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
JS raw 1.87 MB 1.87 MB -159 B
JS gzip 598.8 kB 598.7 kB -36 B
npm tarball 714.5 kB 1.61 MB +890.6 kB
npm unpacked 2.50 MB 6.26 MB +3.77 MB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.4 ms 28.3 ms +1.0 ms
CLI --help 57.5 ms 59.2 ms +1.7 ms

Top changed chunks: no changes in the largest emitted chunks.

@thymikee thymikee closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant