You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move the runtime-use and public runtime-fact projections into the descriptor registry and delete the residual capabilities shell. This preserves descriptor-derived admission, action-selected use semantics, and public-command filtering without a compatibility re-export.
Validation
Focused descriptor/inventory/eager-closure tests: 340 passed.
Layering: 150 passed. pnpm check:affected --run completed all 3,410 tests on the final retry; Vitest reported existing parallel-load teardown errors, while the affected suites pass in isolation.
GitHub-authoritative device lanes remain for CI.
[P2] Current main now rejects implementation comments that preserve review history or narrate control flow, but the edited gesture-facts.ts header still carries R52/R53 and retired core/capabilities provenance. Remove that narrative; let the fact table, symbols, and tests express the invariant, with history remaining in the ADR/PR.
The descriptor-projection move itself is sound, but this head is not ready while Integration Tests is red on daemon SIGTERM cleanup and iOS Smoke is pending.
Addressed the P2 in c09f421 by removing the R52/R53 and retired-capability provenance header from packages/platform-apple/src/gesture-facts.ts. The fact table and behavior are unchanged. The new commit is pushed; CI has restarted. The prior Integration Tests failure was the unrelated live web smoke assertion that the daemon exited after SIGTERM.
The capabilities-shell deletion is functionally clean: both projections now read unchanged semantics directly from the descriptor registry. Not ready yet: the gesture-facts follow-up removed only its header; delete the remaining retired-admission/control-flow narration, especially lines 51-55, 62-65, and 98-101. Exact-head iOS is also red on TEXT_INPUT_COMMIT_NOT_OBSERVED; apparently unrelated, but it must rerun green before readiness.
Addressed this comment in 24cac91: removed the remaining private-helper admission/control-flow/history narration from packages/platform-apple/src/gesture-facts.ts, including the cited ranges. The exported projection documentation and fact behavior are unchanged. The local affected gate passed (415 files, 3,410 tests); exact-head GitHub checks are now rerunning, including iOS Smoke.
Code review is clean at 24cac913a6: the delta removes all previously cited implementation/history narration without changing semantics. All non-iOS checks are green. Exact-head iOS still fails on the gesture-pan replay; current main is also red on a different iOS scenario, so this appears lane instability rather than a code finding, but require a green rerun or same-load base comparison before merge readiness.
Preview removed because the pull request was closed.
2026-08-27 18:14 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the runtime-use and public runtime-fact projections into the descriptor registry and delete the residual capabilities shell. This preserves descriptor-derived admission, action-selected use semantics, and public-command filtering without a compatibility re-export.
Validation
Focused descriptor/inventory/eager-closure tests: 340 passed.
Layering: 150 passed.
pnpm check:affected --runcompleted all 3,410 tests on the final retry; Vitest reported existing parallel-load teardown errors, while the affected suites pass in isolation.GitHub-authoritative device lanes remain for CI.