-
-
Notifications
You must be signed in to change notification settings - Fork 325
feat: add optional Doublespeed provider plugin #2112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hassantsyed
wants to merge
13
commits into
callstack:main
Choose a base branch
from
hassantsyed:feat/doublespeed-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8dad650
feat: add direct Doublespeed provider runtime
hassantsyed 854122d
Merge remote-tracking branch 'origin/main' into migrate/doublespeed-p…
thymikee 4b81820
feat: support provider-owned plugin connections and WebDriver adapters
thymikee f3e6d04
chore(gates): expose the optional WebDriver plugin configuration
thymikee de9d798
feat: share plugin connection and WebDriver adapter infrastructure
thymikee 698503e
feat: ship Doublespeed as an optional provider plugin
thymikee f4f6d14
chore(gates): track standalone provider plugin packaging and boundaries
thymikee af17f66
fix: keep plugin contracts below CLI policy and use scoped test scratch
thymikee 1096a82
fix: preserve provider tests through development-only package exports
thymikee 2126cbc
chore(gates): validate plugin lifecycle and declare packaging fixture…
thymikee 6560af2
chore(gates): smoke the optional packed WebDriver plugin SDK
thymikee fda055e
perf: keep plugin engines and connection metadata out of eager imports
thymikee ca1a7c7
chore(gates): bound the optional plugin SDK declarations
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -444,7 +444,7 @@ export function formatRole(type: string): string { | |
| /** | ||
| * The channel↔producer pairs that can actually occur. One channel is fed by several producers | ||
| * with different guarantees: `xctest` trees come from the local Apple runner, Appium | ||
| * page-source XML, or a limrun element tree, and only the runner's output has been through the | ||
| * page-source XML, or a Limrun or Doublespeed element tree, and only the runner's output has been through the | ||
| * runner's presentation (clip fold, effective geometry, scope). Logic that assumes | ||
| * presentation, scope, or geometry guarantees must key on the producer, never on the channel | ||
| * alone. | ||
|
|
@@ -458,7 +458,12 @@ export function formatRole(type: string): string { | |
| export type SnapshotProvenance = | ||
| | { | ||
| backend: 'xctest'; | ||
| producer: 'apple-runner' | 'simulator-ax-bridge' | 'appium-source' | 'limrun-ios-tree'; | ||
| producer: | ||
| | 'apple-runner' | ||
| | 'simulator-ax-bridge' | ||
| | 'appium-source' | ||
| | 'limrun-ios-tree' | ||
| | 'doublespeed-ios-tree'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: R74 still omits Prompt for AI agents |
||
| } | ||
| | { backend: 'android'; producer: 'android-uiautomator' | 'appium-source' } | ||
| | { backend: 'harmonyos-arkui'; producer: 'harmonyos-uitest' } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| { | ||
| "name": "@agent-device/doublespeed", | ||
| "version": "0.1.0", | ||
| "private": false, | ||
| "type": "module", | ||
| "description": "Doublespeed iOS simulator plugin for agent-device.", | ||
| "exports": { | ||
| ".": { | ||
| "types": "./src/index.ts", | ||
| "default": "./src/index.ts" | ||
| }, | ||
| "./connection-verification": { | ||
| "types": "./src/connection-verification.ts", | ||
| "default": "./src/connection-verification.ts" | ||
| }, | ||
| "./package.json": "./package.json" | ||
| }, | ||
| "files": [ | ||
| "dist" | ||
| ], | ||
| "scripts": { | ||
| "build": "tsdown --config tsdown.config.ts", | ||
| "prepack": "pnpm build" | ||
| }, | ||
| "devDependencies": { | ||
| "@agent-device/capture-kit": "workspace:*", | ||
| "@agent-device/contracts": "workspace:*", | ||
| "@agent-device/kernel": "workspace:*", | ||
| "agent-device": "workspace:*" | ||
| }, | ||
| "agentDevicePlugin": { | ||
| "apiVersion": 1, | ||
| "provider": "doublespeed", | ||
| "entry": "./dist/plugin.mjs", | ||
| "connection": { | ||
| "leaseKind": "direct-device-provider", | ||
| "requiresAppAttachment": false, | ||
| "requiresRemoteDaemon": false, | ||
| "supportsArtifacts": false, | ||
| "supportsDeferredAppSelection": true, | ||
| "supportsDirectPortReverse": false, | ||
| "usesCloudWebDriverLease": false | ||
| } | ||
| }, | ||
| "publishConfig": { | ||
| "exports": { | ||
| ".": { | ||
| "import": "./dist/plugin.mjs" | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: This addition makes the adjacent contract comment inaccurate: it omits Doublespeed from the provider list and says truncation covers four producers, though the union now has five. Update the comment to include Doublespeed and the new count.
Prompt for AI agents