Skip to content

fix(conformance): isolate post-tap settling from app launch - #2390

Merged
thymikee merged 1 commit into
mainfrom
fix/conformance-settle-startup
Sep 8, 2026
Merged

thymikee merged 1 commit into
mainfrom
fix/conformance-settle-startup

Conversation

@thymikee

@thymikee thymikee commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

Fix the settle-after-tap scenario from failed run 34086351141. Both engines passed every flow, but the Settings tap recorded one settle latch and one timeout: per-command metrics also include the deferred launch boundary.

Add an explicit visual wait before the measured tap so launch stabilization cannot contaminate its inline-settle counters. Keep the zero-timeout and proof-of-life invariants unchanged. Three files changed: the flow, its semantic guard, and a runtime regression executing that checked-in flow with slow startup snapshots.

Validation

Tested commit: f80dc2c3e1.

  • Regression observed red before the fix with the CI signature (3 captures, 1 latch, 1 timeout), then green (2 captures, 1 latch, 0 timeouts).
  • Focused runtime suite: 7 passed; differential invariant suite: 26 passed.
  • pnpm check:affected --run: all runnable checks passed, including typecheck, lint, layering, build, packaging, and Node integration.
  • CI and the live iOS differential rerun are pending. No production runtime behavior changed.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.51 MB 4.51 MB 0 B
Package (unpacked) 4.51 MB 4.51 MB 0 B
Package (download) 1.34 MB 1.34 MB -7 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 23.0 ms 23.2 ms +0.2 ms
CLI --help 60.2 ms 62.6 ms +2.3 ms

@thymikee

thymikee commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

The visual wait at f80dc2c separates launch stabilization from the measured tap without weakening the settle invariants, and the regression exercises the checked-in flow. No code findings. Exact-head iOS differential and smoke runs are now green; ready for human review.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 8, 2026
@thymikee
thymikee merged commit be62249 into main Sep 8, 2026
19 checks passed
@thymikee
thymikee deleted the fix/conformance-settle-startup branch September 8, 2026 08:37
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-08 08:38 UTC

thymikee added a commit that referenced this pull request Sep 8, 2026
…cope-contracts

* origin/main: (25 commits)
  fix(ios): avoid duplicate alert routing queries (#2398)
  docs(adr): record the #2278 coupling audit and re-trace entry-to-platform hops (#2355)
  chore(gates): classify #2278 daemon-platform-runtime edges and ratchet handler session authority (#2354)
  test(capture): shrink the 3x crop fixture to avoid coverage timeouts (#2399)
  perf(ios): settle the first interaction on a deadline, not a fixed sleep (#2395)
  feat: support standalone Maestro clearState command (#2366)
  refactor(capture-kit): complete ADR 0019 end state — relocate snapshot and recording zones (#2385)
  refactor(ios): delete the unused snapshot plan interface (#2392)
  fix(conformance): isolate post-tap settling from app launch (#2390)
  test(remote): assert the proxied snapshot's whole wire conversation (#2387)
  fix(daemon): stop an attested tenant from downgrading its own isolation (#2386)
  refactor(ios): prune converged snapshot paths (#2383)
  refactor(move): move the batch runner and batch policy into @agent-device/command-registry (#2388)
  fix(remote): let a plain-session client read its own failure record (#2382)
  refactor(move): move replay divergence vocabulary into @agent-device/ad-replay (#2384)
  refactor(cli): take the CLI's vocabulary off runtime barrels (#2379)
  perf(cli): keep scroll vocabulary off gesture runtime (#2378)
  chore: drop the stale planned-operations closure approval (#2373)
  fix(gates): stop an eager-closure approval from turning main red on merge (#2375)
  fix(ios): honor the startup budget through a cold Simulator boot (#2325)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant