Conversation
Member
|
Code review is clean at 865ed65. Explicit launchApp.appId values preserve app switches, relaunch options and deep-link order through the existing runtime, and the regressions cover the previous rejection. Checks pass and there are no conflicts; ready for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replay exportnow preserves app switches in recorded flows:Each launch carries its own
launchApp.appId; the first app remains the flow default. This completes the existing local export workflow from #751 using already-supported Maestro syntax. Relaunch options and deep links retain their authored targets and order.Eight files (+94/−32): exporter, behavioral regressions, CLI help, user docs, and changelog.
Validation
Tested commit:
865ed651a5b3b20c79b69b1ade0b2d236c905b3b(Linux arm64, Node 24.13.1, pnpm 11.17.0).main(64867883) and pass with this change.pnpm exec vitest run packages/maestro/src/internal/__tests__/export-navigation.test.ts packages/maestro/src/internal/__tests__/export-label-projection.test.ts src/cli/commands/__tests__/replay-maestro-export.test.ts: 19 passed.pnpm maestro:conformance: 62 passed.pnpm check:affected --run: passed, including build, formatting, lint, types, layering, Fallow, and 2,193 related tests across 294 files.--out, help, and unsupported-action refusal passed with an unreachable daemon URL.Initial validation exposed missing host
zip/unzipand a startup timeout. Archive tools are now provisioned; the final gate passed with four workers and unchanged test limits. CI is pending; full Coverage and Integration Tests remain GitHub-authoritative.