Repository navigation
fix(ios): keep an identifier hook the fold cannot prove inert - #2643
Merged
Merged
Conversation
Suppressing a childless structural identifier wrapper deletes its identifier from every canonical view, and the interactive fold did it on a missing fact: the Apple runner declares hittable:false for those wrappers, the Simulator AX bridge declares nothing, and the same testID hook resolved on one producer and vanished on the other. Suppression now needs the node's own declared verdict. Refs #2638
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Reviewed at 35d1a35. The fold now suppresses a childless identifier-only wrapper only when the node itself declares Smoke Tests fails on |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectIosStructuralIdentifierSuppressiondeleted a childlessOtherwrapper carrying only anidentifier, assuming its content would carry that identifier onward. A childless wrapper has nothing
to delegate to, so the identifier left every canonical view while
is,get, andclickstillresolved it from the same capture. Whether a wrapper arrives childless is decided by a fact the
producer may not report at all: the Apple runner answers
hittablefor every node, the Simulator AXbridge for none. Suppression now requires the node's own declared
hittable: false(ADR 0004).On one screen of one installed app,
snapshot -iover both producers now yields identical 18-hooksets:
home-title,gesture-lab-card,drag-gesture-fixtureandgesture-metricsare addressableunder Simulator AX, as they already were under XCTest. Refs #2638. Out-of-process surfaces in that
report (PHPicker, MapLibre annotation content) are not this rule and still need raw captures. 7
touched files.
Validation
Tested at
35d1a35f77087f0412b644d49df073d9d45bbe4f.pnpm check:affected --run: all runnable checks passed (2163 tests).noise.test.tsanddaemon-runtime-port-identifier-hook.test.ts. The delegation case and both negatives stay green;they pin unchanged behavior.
examples/test-app:snapshot -i --jsonidentifier sets identicalacross producers (18 vs 18, none one-sided); a Maestro flow asserting
home-titlethengesture-lab-cardreports1 passed;is visible 'id="home-title"'passes.it is pinned at the adapter seam.
Risk: a bridge capture has no occlusion signal, so a hook behind an in-app modal can read visible —
predates this change, covers every bridge node. Sessions closed; simulator
2638-verifyleft booted.