fix(providers): name the simulator HID helper in the fold refusal hints - #2873
Merged
Merged
Conversation
Since #2762 fold poses a foldable iPhone simulator by spawning a HID sender inside a host simulator (simctl spawn), not through Xcode Device Hub. Reword the Limrun and WebDriver refusal hints and the comments that still described the Device Hub path. Refusal reasons and codes are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Reviewed at 96a901b. This changes only hint text and comments: the fold refusal hints in contracts, limrun and webdriver now name the simulator HID helper. The refusal reason and availability are unchanged, and the tests match on Checks were still running at review time. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the review on #2821. Since #2762,
foldbuilds a small HID helper and runs it withsimctl spawninside a foldable iPhone simulator on the daemon host (packages/platform-apple/src/foldable/simulator-hid.ts). It no longer goes through Xcode Device Hub. The Limrun and WebDriver refusal hints still said Device Hub, so they now name what fold actually needs:Refusal reasons and codes are unchanged (
unsupported-provider-mode). Five comments that still described fold as using Device Hub were also reworded: theFoldCommandResultdoc in contracts, Android and web runtime tests, and two provider-scenario integration comments. 7 files, comment and hint text only.git grep -i "device hub"now finds only:Validation
At
96a901b01,pnpm check:affected --runpassed: 17 checks, including 121 files / 814 tests. No test pins the hint text: provider tests compare against the constants, and the integration test matches/fold/. This changes no runtime behavior, so no device run applies.An adversarial review found three issues, all fixed here:
🤖 Generated with Claude Code