Skip to content

fix(providers): name the simulator HID helper in the fold refusal hints - #2873

Merged
thymikee merged 1 commit into
mainfrom
fix/fold-refusal-hint-simulator-hid
Sep 24, 2026
Merged

thymikee merged 1 commit into
mainfrom
fix/fold-refusal-hint-simulator-hid

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Follow-up to the review on #2821. Since #2762, fold builds a small HID helper and runs it with simctl spawn inside a foldable iPhone simulator on the daemon host (packages/platform-apple/src/foldable/simulator-hid.ts). It no longer goes through Xcode Device Hub. The Limrun and WebDriver refusal hints still said Device Hub, so they now name what fold actually needs:

fold runs a HID helper through simctl spawn inside a foldable iPhone simulator on the daemon host; a Limrun session has no such simulator.

Refusal reasons and codes are unchanged (unsupported-provider-mode). Five comments that still described fold as using Device Hub were also reworded: the FoldCommandResult doc in contracts, Android and web runtime tests, and two provider-scenario integration comments. 7 files, comment and hint text only.

git grep -i "device hub" now finds only:

  • ADR 0025 and CHANGELOG, which are historical;
  • docs and help text that say Device Hub is not required;
  • references to Device Hub's preset names and the angles measured from them.

Validation

At 96a901b01, pnpm check:affected --run passed: 17 checks, including 121 files / 814 tests. No test pins the hint text: provider tests compare against the constants, and the integration test matches /fold/. This changes no runtime behavior, so no device run applies.

An adversarial review found three issues, all fixed here:

  • the Android comment wrongly claimed no adb surface can pose a hinge;
  • the first hint wording was vague;
  • an integration comment claimed a check the test doesn't make.

🤖 Generated with Claude Code

Since #2762 fold poses a foldable iPhone simulator by spawning a HID sender
inside a host simulator (simctl spawn), not through Xcode Device Hub. Reword
the Limrun and WebDriver refusal hints and the comments that still described
the Device Hub path. Refusal reasons and codes are unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.80 MB 4.80 MB +73 B
Package (unpacked) 4.80 MB 4.80 MB +73 B
Package (download) 1.44 MB 1.44 MB +41 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 30.7 ms 32.8 ms +2.0 ms
CLI --help 85.2 ms 90.8 ms +5.6 ms

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at 96a901b. This changes only hint text and comments: the fold refusal hints in contracts, limrun and webdriver now name the simulator HID helper. The refusal reason and availability are unchanged, and the tests match on /fold/, not on the exact hint, so no caller depends on the old wording.

Checks were still running at review time.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 24, 2026
@thymikee
thymikee merged commit 1b31bee into main Sep 24, 2026
18 checks passed
@thymikee
thymikee deleted the fix/fold-refusal-hint-simulator-hid branch September 24, 2026 09:35
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-24 09:35 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant