ci(diagnose): retire the 1874 diagnose loop - #2875
Merged
Merged
Conversation
The loop's default test stopped reaching a commit wait in #2845: it asserts route xctest-element, so a default dispatch collects no [DEBUG-1874] cadence. That test never reached #2080's route, even before #2845. It is a bare `type`, and the synthesized-first-responder-replacement route fires only for `fill` on a penalized XCTest channel. So this loop was never #2080's reproduction path. No existing RunnerTests method reaches the real replacement route. The one test that reaches its commit wait (testTypeTextReliablyPacesSynthesizedReplacementThroughProductionCaller) uses a recording synthesizer against Springboard, so every poll reads nil and the wait always ends notObserved at the 3 s stall deadline. Looping it records a fixed, synthetic cadence. A new penalized coordinate-fill test could reach the route, but the cadence records lengths only (#1924), so it still could not capture the corrupted value #2080 needs. #2080's triage asks for a local reproduction with test-only value instrumentation instead. Delete the workflow, its iteration reader, and that reader's test. The runner's [DEBUG-1874] lines stay: runner.log in the iOS smoke lane is where the #2080 trace came from, and existing tests pin their format and redaction. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Reviewed at f688878. The deletion looks clean: it removes the diagnose workflow, the script, its test, and the matching line in The failing Smoke Tests job is a live iOS run. It fails at |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the review on #2845. The review noted that
1874-diagnose.ymldefaults totestBareTypeUsesTappedInputWhenSoftwareKeyboardIsHidden. After #2845 that test asserts routexctest-elementand never reaches a[DEBUG-1874]commit wait. Of the two options (repoint the default or retire the workflow), this PR retires it.type. ios: fill's synthesized-replacement route lands a corrupted value (traced: 11 chars requested, 7 observed, frozen) #2080'ssynthesized-first-responder-replacementroute fires only forfillon a penalized XCTest channel, so the default test did not reach it before refactor(ios-runner): restrict the tap-witness synthesized type route to the bare submit key #2845 either.testTypeTextReliablyPacesSynthesizedReplacementThroughProductionCallerreaches the replacement commit wait. It uses a recording synthesizer against Springboard, so every poll reads nil and it always endsnotObservedat the 3 s deadline. The cadence it logs is fixed and synthetic.type-allduration, which only mattered for ios: text-entry lanes fail intermittently on unrelated branches (unpinned simulator keyboard state) #1874, now closed.Deleted: the workflow,
scripts/diagnose-1874-iteration.ts, its test, and that test'svitest.config.tsentry (4 files, −370). The runner's[DEBUG-1874]lines stay. The #2080 trace came from them in the smoke lane'srunner.log, and existing tests pin their format and redaction.Validation
pnpm check:affected --runpassed: 59 checks selected (including fallow and build), GitHub-authoritative lanes not run locally. It ran at120233a7a, which has the same tree as the pushedf6888782f; only the commit message was reworded.pnpm check:xctest-selection: 308 methods, 0 reachable by no lane.git grepfinds no leftover references.🤖 Generated with Claude Code