Conversation
Size Report
Startup median (7 runs, lower is better):
|
|
Reviewed at fa4c326. The change itself is a non-functional comment in the E2E-owned iOS XCTest file, so it carries no correctness risk on its own. Smoke Tests/Coverage is still in progress, so this isn't a failure, it's the measurement the PR exists to produce. The PR body quotes a local I didn't review #2896's selector logic itself, since this PR is only exercising it, not implementing it. |
fa4c326 to
c650da5
Compare
|
The iOS job on The macOS job on that head was cancelled when #2896 merged and this probe was rebased onto |
|
This is a follow-up to the earlier review on fa4c326. The macOS bridge-proof job for the rebased head c650da5 (run 36029774856/job 107735285506) has completed and logged "Apple bridge proof: skip; the PR changed no Apple implementation or gate tooling." The sibling iOS job for the same head (run 36029774629/job 107735283335) is still queued with zero steps run, so the iOS-side skip confirmation this probe exists to gather has not been produced on this head yet. Without that job, the PR cannot be closed with the evidence it was opened to collect: https://github.com/callstack/agent-device/blob/c650da5/test/integration/ios-simulator-e2e/live-webview-remote-content.ts#L8 states the deliverable as live confirmation, on this exact head, that the affected-check model selects skip for the iOS XCTest lane. Closing before that job finishes would leave the post-#2896 iOS skip path unverified on the rebased head. Wait for run 36029774629/job 107735283335 to finish, then check for the "iOS XCTest: skip" selector line, the targeted-XCTest step showing skipped, and a passing "Assert iOS XCTest selection was honored" step. Once those three show up, this draft can be closed without merging. CI is pending. The queued Smoke Tests (iOS) job on c650da5 is not a failure or an unrelated gate; it is the exact route this probe PR was opened to measure. For the earlier fa4c326 head, the skip was inferred from the step list (targeted iOS runner XCTest regressions shown skipped, "Assert iOS XCTest selection was honored" passed) via |
|
The requested exact-head proof is complete. iOS Smoke Tests on The iOS job queued 47m20s and ran 11m30s (58m50s from creation). #2896's exact-head job queued 29m01s and ran 24m44s (53m45s total). This pair saved 13m14s on the runner but finished 5m05s later because of queue time. Settings and gesture passed first try on this probe; the earlier probe head had retries. The measurement is complete, so I am closing this draft without merging. |
|
Summary
Disposable measurement PR on
main. One comment in an iOS E2E-owned file triggered iOS and macOS smoke without changing runner code. The exact-head runs confirmed the affected selectors skip iOS XCTest and Apple bridge proof. One file changed; do not merge.Validation
Exact head
c650da540c:pnpm check:affected --base HEAD^ --head HEAD --runpassed. The iOS job loggediOS XCTest: skip, skipped targeted XCTest, passed the selection assertion, and took 11m30s on the runner after 47m20s queued. Settings and gesture each passed on the first attempt. The macOS job loggedApple bridge proof: skipand skipped its proof step. A prior probe head took 18m55s on the runner because Settings and gesture retried. #2896's exact-head iOS job took 24m44s running after 29m01s queued. The current probe saved 13m14s of runner time in this pair but finished 5m05s later from job creation because of the queue.