docs(ios): state the fold's clipped-carrier hittability as false, not nil - #2958
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apple/snapshot-presentation/Sources/AgentDeviceSnapshotPresentation/SnapshotVisibilityFold.swift">
<violation number="1" location="apple/snapshot-presentation/Sources/AgentDeviceSnapshotPresentation/SnapshotVisibilityFold.swift:246">
P3: This sentence is ungrammatical and makes the corrected clipping scenario ambiguous. Say that the carrier was clipped to nothing by a scroll anchor.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| /// open question. A `visibilityExempt` carrier clipped to nothing by a scroll anchor is that | ||
| /// `nil` today, and its own frame already answers the question. | ||
| /// source left undecided is re-decided on the clipped frame: a disabled or degenerate frame — | ||
| /// including a `visibilityExempt` carrier a scroll anchor clipped to nothing — answers `false`, |
There was a problem hiding this comment.
P3: This sentence is ungrammatical and makes the corrected clipping scenario ambiguous. Say that the carrier was clipped to nothing by a scroll anchor.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apple/snapshot-presentation/Sources/AgentDeviceSnapshotPresentation/SnapshotVisibilityFold.swift, line 246:
<comment>This sentence is ungrammatical and makes the corrected clipping scenario ambiguous. Say that the carrier was clipped to nothing by a scroll anchor.</comment>
<file context>
@@ -242,10 +242,10 @@ public enum SnapshotVisibilityFold {
- /// open question. A `visibilityExempt` carrier clipped to nothing by a scroll anchor is that
- /// `nil` today, and its own frame already answers the question.
+ /// source left undecided is re-decided on the clipped frame: a disabled or degenerate frame —
+ /// including a `visibilityExempt` carrier a scroll anchor clipped to nothing — answers `false`,
+ /// and `nil` stays reserved for the one question the clipped frame cannot answer, containment
+ /// while the capture has no viewport box.
</file context>
| /// including a `visibilityExempt` carrier a scroll anchor clipped to nothing — answers `false`, | |
| /// including a `visibilityExempt` carrier clipped to nothing by a scroll anchor — answers `false`, |
|
Reviewed at 493be9e. This is a comment-only doc fix, and the change matches the code: the fold's clipped carrier is documented as All 19 checks are green, and none of them exercise a route beyond the doc text since nothing but wording changed. I did not re-run the iOS differential or golden-table suite locally for this PR; the confirmation rests on #2945's merged validation and the static read above. This is ready for human review. |
|
Summary
Follow-up on #2945 (cubic inline review,
SnapshotVisibilityFold.swift:248). TheclippedHittabilitydoc comment claimed avisibilityExemptcarrier clipped to nothing by a scroll anchor is thenilcase. It is not: the degenerate clipped frame failsisPositiveFiniteand answersfalse;nilstays reserved for containment being undecidable while the capture has no viewport box. Comment-only correction; the implemented policy is unchanged and correct.Validation
Head
493be9eeef. Docs-only: no runtime behavior changes, so no device or CLI runs apply.swift test --package-path apple/snapshot-presentation: 17/17 pass.pnpm check:affected --runresult will be recorded by the CI gate stage on this head.