fix(ios-runner): keep the text-entry fixture inside the iOS guard so tvOS builds - #2975
Merged
Merged
Conversation
…tvOS builds The burst helper and its status writer sit below the #endif that closes TARGET_OS_IOS, while agentDeviceTextEntryDidChange: compiles for tvOS and calls them, so build:xcuitest:tvos refuses the translation unit and build:package fails before npm publish. No CI lane builds the tvOS or visionOS runner, so the guard stayed broken on main. viewDidLoad creates that fixture only under the same iOS guard, so the helpers belong inside it.
|
Size Report
Startup median (7 runs, lower is better):
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm publishon main fails with exit 65.updateTextEntryWriteBackStatusand the text-entry burst helpers sit below the#endifthat closes#if TARGET_OS_IOS, whileagentDeviceTextEntryDidChange:compiles for tvOS and calls them, sobuild:xcuitest:tvosrefuses the translation unit andbuild:packagedies insideprepack.viewDidLoadcreates that fixture only under the same iOS guard, so the fix moves the#endifdown to keep the whole fixture inside it. One touched file, one moved#endif.The break landed in
64854afa1d, which no tag contains, so only the unreleased 0.21.15 is affected. No CI lane builds the tvOS or visionOS runner (ios.ymlandxctest-nightly.ymlare iOS,macos.ymlis macOS), which is why main stayed red.Validation
Tested at 3fdebeb.
xcrun --sdk appletvsimulator clang -fsyntax-onlyon the parent commit's file reproducesno visible @interface for 'AgentDeviceRunnerViewController' declares the selector 'updateTextEntryWriteBackStatus'; the fixed file compiles clean for both tvOS and visionOS SDKs.pnpm build:xcuitest:tvos,:visionos,:iosall reach** TEST BUILD SUCCEEDED **.pnpm build:package,pnpm check:package, andpnpm release:preparepass;release:prepareproduces the tarball that previously could not be built.pnpm check:xctest-selectionunchanged at 0 methods reachable by no lane: the guard change moves Objective-C app-fixture code, not an XCTest#if.pnpm check:affected --runreports all runnable checks passed. Its first run flagged oneapple-runnerwall-clock slow test (5.02s against a 2.5s budget) on a host at load average 21; the file passes in 3.67s and the rerun is clean, so that was contention on this host rather than this change.prepackthat stops requiring artifacts nothing builds before release, would prevent a recurrence.