-
-
Notifications
You must be signed in to change notification settings - Fork 315
fix(ios): give boot a --timeout startup budget #3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -714,7 +714,9 @@ export const RAW_COMMAND_DESCRIPTORS = [ | |
| sessionKind: 'state', | ||
| }, | ||
| platformExecution: { kind: 'device-runtime', uses: deviceBootRuntimeUses }, | ||
| timeoutPolicy: DEFAULT_TIMEOUT_POLICY, | ||
| // --timeout is a startup budget: it reaches the Simulator boot wait, same as open/prepare | ||
| // (#2325). A first boot can outlast the fixed 90s envelope (#3004). | ||
| timeoutPolicy: { ...DEFAULT_TIMEOUT_POLICY, budget: { source: 'flag', envelope: 'margin' } }, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The new Prompt for AI agents |
||
| batchable: true, | ||
| }, | ||
| { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Converts a `--timeout <ms>` startup budget into the absolute deadline a readiness wait honors. | ||
| * A missing, non-finite, or non-positive budget yields `undefined`, so callers fall back to their | ||
| * own default wait instead of silently disabling it. | ||
| */ | ||
| export function startupDeadlineAtMs(timeoutMs: unknown): number | undefined { | ||
| return typeof timeoutMs === 'number' && Number.isFinite(timeoutMs) && timeoutMs > 0 | ||
| ? Date.now() + timeoutMs | ||
| : undefined; | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: This shared Boot help text is inaccurate for Android users:
bootalso launches Android emulators, but the description says the budget covers only a Simulator boot. Describe this as a device boot or as a Simulator/emulator boot.Prompt for AI agents