Skip to content

refactor(replay): move dispatch projections into replay-port - #3022

Merged
thymikee merged 1 commit into
codex/2663-replay-command-typesfrom
codex/2663-replay-dispatch
Sep 28, 2026
Merged

thymikee merged 1 commit into
codex/2663-replay-command-typesfrom
codex/2663-replay-dispatch

Conversation

@thymikee

@thymikee thymikee commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Move replay request envelope handling and Maestro operation dispatch projection, with their paired tests, into @agent-device/replay-port. Daemon handlers and replay runtime code now import the owning package subpaths. Remove the old daemon replay facade exports and layering declarations.

This dependent #2663 slice builds on #3019. Both production modules are byte-for-byte moves; the request-envelope test now uses the package contract type in place of a daemon-private type.

Validation

  • Exact head a075e695658d0c0cc3c7744bd161ca7b397e62e0: pnpm check:affected --run passed (606 test files, 5,365 tests; separate 12-test suite passed).
  • The two moved tests passed (8 tests).
  • pnpm typecheck and the tracked-file layering check passed.
  • pnpm format ran repository-wide.

Live .ad and Maestro replay characterization remains for the completed package move.

@thymikee
thymikee added this pull request to stack #3020 September 28, 2026 11:05
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.87 MB 4.87 MB -2 B
Package (unpacked) 4.87 MB 4.87 MB -2 B
Package (download) 1.46 MB 1.46 MB +25 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 18.4 ms 18.9 ms +0.5 ms
CLI --help 52.4 ms 52.7 ms +0.3 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Re-trigger cubic

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstack.github.io/agent-device/pr-preview/pr-3022/

Built to branch gh-pages at 2026-09-28 16:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at 6a02e05, and checked again at a075e69, which only rebases onto the updated #3019 and merges the package.json exports and imports the files that #3007 moved from their new place. The dispatch projections move into replay-port unchanged, and the test type swap keeps the same coverage. No blocking issues.

CI: checks on a075e69 are still running. This PR stacks on #3019, which must land first.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 28, 2026
@thymikee
thymikee force-pushed the codex/2663-replay-dispatch branch from a075e69 to 38cd04a Compare September 28, 2026 16:35
@thymikee
thymikee merged commit 4bb674f into main Sep 28, 2026
28 of 39 checks passed
@thymikee
thymikee deleted the codex/2663-replay-dispatch branch September 28, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant