Skip to content

refactor(contracts): drop unused FOLD_SCREEN_COORDINATE_SPACE mirror from fold-runtime - #3054

Merged
thymikee merged 1 commit into
mainfrom
claude/remove-duplicate-fold-export-d57782
Sep 29, 2026
Merged

thymikee merged 1 commit into
mainfrom
claude/remove-duplicate-fold-export-d57782

Conversation

@thymikee

@thymikee thymikee commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Removes the unused FOLD_SCREEN_COORDINATE_SPACE mirror in fold-runtime.ts; device-rotation.ts stays the single declaration. All importers (facades/device.ts, platform-apple/src/foldable/pose.ts, src/commands/system/index.ts) already read it via @agent-device/contracts/device. The remaining fold-runtime.ts import is type-only, so its eager closure is unchanged. fallow audit --base origin/main is clean.

Review in cubic

@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.88 MB 4.88 MB 0 B
Package (unpacked) 4.88 MB 4.88 MB 0 B
Package (download) 1.46 MB 1.46 MB -1 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.7 ms 27.5 ms +0.8 ms
CLI --help 81.4 ms 82.1 ms +0.7 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@thymikee

Copy link
Copy Markdown
Member Author

Looks good at 7b3fcc3. The PR only deletes an unused constant from fold-runtime.ts. Nothing on the PR head imports it, and the canonical FOLD_SCREEN_COORDINATE_SPACE in device-rotation.ts stays.

The failing Smoke Tests job reports "Daemon lock is held by another process" in the iOS runner preflight. This diff does not touch daemon startup or locking, so the failure looks unrelated. Please re-run Smoke Tests. There are no conflicts, and no code change is needed.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 29, 2026
@thymikee
thymikee merged commit 8b90931 into main Sep 29, 2026
18 of 19 checks passed
@thymikee
thymikee deleted the claude/remove-duplicate-fold-export-d57782 branch September 29, 2026 12:42
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-29 12:43 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant