You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
setWebDriverOrientation tries two routes and, when the driver refuses both as not implemented, threw a COMMAND_FAILED with attempts only: no reason, no dispatched. The router then stamped that failure dispatched: unknown although nothing reached the device. Found by cubic on #3090.
webdriver-transport.ts: the one owner of the refusal details, unsupportedRouteRefusal() (reason: webdriver_route_unsupported, dispatched: no), used by webdriverError and now by the orientation fallback's final error.
webdriver-orientation.ts: the every-route-refused error carries those details beside rotation and attempts.
Golden table: one row, webdriver.orientation.every-route-unsupported → no, driven in webdriver-orientation.test.ts (the owner map gains the webdriver.orientation. prefix). Mutation: dropping the spread fails the row and the existing both-endpoints test.
I found no code problems at f4f2ca5. When every orientation route refuses the request, the WebDriver provider now reports dispatched no, which matches the fact that nothing reached the device.
CI is still running: Smoke Tests is in progress and has no failure so far. I did not run anything locally, so the validation list in the PR body is unverified by me. I also did not trace the request router to confirm it keeps a producer-set dispatched no instead of replacing it with unknown. The PR body and the unclassified-dispatch handling in the kernel errors module both point that way.
I did not do a hosted WebDriver run, and I do not think one is needed, because the change only adds error details on a path that never reached the device. No conflicts. Once Smoke Tests finishes green, this is ready, and I am not asking for any code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setWebDriverOrientationtries two routes and, when the driver refuses both as not implemented, threw aCOMMAND_FAILEDwithattemptsonly: noreason, nodispatched. The router then stamped that failuredispatched: unknownalthough nothing reached the device. Found by cubic on #3090.webdriver-transport.ts: the one owner of the refusal details,unsupportedRouteRefusal()(reason: webdriver_route_unsupported,dispatched: no), used bywebdriverErrorand now by the orientation fallback's final error.webdriver-orientation.ts: the every-route-refused error carries those details besiderotationandattempts.webdriver.orientation.every-route-unsupported→no, driven inwebdriver-orientation.test.ts(the owner map gains thewebdriver.orientation.prefix). Mutation: dropping the spread fails the row and the existing both-endpoints test.Part of #3069. +1 row (80).
Validation
webdriver-orientation.test.ts,webdriver-transport.test.ts,contracts/dispatch-disclosure.test.ts(40 tests),pnpm typecheck,check:layering,check:fallow --base 8c0edab4c7, oxfmt on the five files.