refactor: resolve session artifact paths without a store - #3134
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
This PR is ready at 64f40ac. The code looks right, and the moved tests keep their assertions. All 14 checks pass, and there are no conflicts. It waits only on its base, #3133, landing. Not blocking, and you can take or leave these: device-claim-reconciliation.ts line 28 still joins |
5411c0b to
7c81188
Compare
64f40ac to
b4a1636
Compare
7c81188 to
c7b6c1e
Compare
b4a1636 to
9a29273
Compare
c7b6c1e to
bbc844f
Compare
9a29273 to
5cbf879
Compare
bbc844f to
e4a21ee
Compare
5cbf879 to
a4efad5
Compare
|
|
#3186 lands the unchanged path-helper patch on The replacement preserves the reviewed patch ( |
Summary
Session directory and app-log paths now come from the existing artifact-path module. Stale-claim recovery resolves paths from the dead owner's state directory directly, without constructing a session store. Store consumers delegate to the same validated functions.
Removes the
SessionStore.expandHomeforwarder and migrates all nine production callers toexpandSessionPath. Path sanitization, errors, filenames and cwd handling are preserved. Moves the existing path tests to their defining modules, retaining their assertions.Depends on #3133. Ref #3116. Ten files, 191 gross changed lines.
Validation
Tested
64f40ac3bf5b081a98b09b204bf72a482c8d3a7d: