Skip to content

test: let the shared Vitest isolation win over a project's own options - #3212

Merged
thymikee merged 1 commit into
mainfrom
claude/vitest-isolation-wins
Oct 5, 2026
Merged

thymikee merged 1 commit into
mainfrom
claude/vitest-isolation-wins

Conversation

@thymikee

@thymikee thymikee commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #3206. TEST_ISOLATION now spreads after each Vitest project's own test block, as the mutation lane already does, so no project can turn unstubEnvs off. This resolves the open P3 review thread on #3206. One line in vitest.config.ts.

Validation

At the pushed head: pnpm check:affected --run passes. A throwaway probe confirmed that a stub made in one test is gone in the next.

Review in cubic

Spread TEST_ISOLATION after each project's test block, as the mutation lane
already does, so no project can turn env isolation off.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.04 MB 5.04 MB 0 B
Package (unpacked) 5.04 MB 5.04 MB 0 B
Package (download) 1.51 MB 1.51 MB -9 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.0 ms 26.5 ms +0.5 ms
CLI --help 75.3 ms 76.9 ms +1.5 ms

@thymikee

thymikee commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

Code looks good at f74c38b. The change only touches the Vitest config, and the shared isolation setting now wins over a project's own options. All checks are passing and there are no conflicts. I did not run the test suite, and I did not find a regression test for the override order, since only the config line changed. Nothing else stands in the way of merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 4, 2026
@thymikee
thymikee merged commit 7faae56 into main Oct 5, 2026
19 checks passed
@thymikee
thymikee deleted the claude/vitest-isolation-wins branch October 5, 2026 05:47
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-05 05:48 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant