test(apple): own the simctl settings plan tests in simctl-settings.test.ts - #3244
Merged
thymikee merged 1 commit intoOct 6, 2026
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
The change in 84686ef looks good. It only moves the simctl settings plan tests into simctl-settings.test.ts, and I found no production code in the diff. The test and table-row names match the originals, but I did not run the tests or compare each assertion's argv and detail strings line by line. CI shows no result: all jobs were cancelled and there are no logs. The diff touches only two test files, so only Lint, Format, and Coverage could be affected by it. Please re-run the cancelled jobs. Stack base #3243 must merge before this PR can land. |
thymikee
added
the
ready-for-human
thymikee
added this pull request to stack #3249
October 6, 2026 05:31
…st.ts app-settings.test.ts drove the simctl plan through setIosSetting and a mocked runner. The plan tests now call applySimctlSetting with a fake runSimctl; app-settings keeps one wiring test each for appearance, permission and location.
thymikee
force-pushed
the
claude/simctl-settings-plan-tests-stacked
branch
from
October 6, 2026 10:37
84686ef to
f6dc810
Compare
|
thymikee
added a commit
to okwasniewski/agent-device
that referenced
this pull request
Oct 6, 2026
* origin/main: (77 commits) fix(apple-runner): fence prep spawns behind a start-owned admission (callstack#3239) 0.21.22 test(apple): own the simctl settings plan tests in simctl-settings.test.ts (callstack#3244) fix(limrun): report the session device id in iOS settings refusals (callstack#3243) 0.21.21 feat(remote): add a host-allocated macos-app lease backend (callstack#3236) test(android): bound the screenshot write wait by wall time, not event-loop turns (callstack#3250) feat(recording): cap the touch overlay frame rate at the caller's --fps (callstack#3241) fix(ad-script): let .ad scripts carry scroll --until and wait capture flags (callstack#3197) (callstack#3234) feat(provider-webdriver): keyboard enter, dismiss, and status over WebDriver (callstack#3233) feat(selectors): match role= against snapshot kind with a node-scoped alias window (callstack#3232) fix(provider-webdriver): read field values, placeholders, secure fields, and checked state from page source (callstack#3231) feat(replay): accept --test-ime on test and replay so flow-owned Android opens opt into the test IME (callstack#3235) refactor(daemon): route daemon-level diagnostics through one scope helper (callstack#3242) docs(adr): correct ADR 0031 pointer event delivery evidence (callstack#3245) fix(ios): stop a tap's post-gesture lookup from recording an XCTest failure (callstack#3060) (callstack#3237) fix(recording): render the touch overlay at most 30 fps and inside the record request (callstack#3219) fix(daemon): keep an idle daemon alive only for retained leases (callstack#3227) fix(provider-webdriver): send an empty JSON object on bodyless POSTs (callstack#3230) Feat/maestro repeat while (callstack#3214) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3243; both change
simctl-settings.test.ts. Retarget tomainafter #3243 merges.Summary
app-settings.test.tstested the simctl settings plan by drivingsetIosSettingwith a mocked runner. That plan lives insimctl-settings.ts, which already has its own test file. The plan tests now callapplySimctlSettingwith a fakerunSimctl.app-settings.test.tskeeps one wiring test each for appearance, permission and location, which check the exact simctl call list on the simulator udid.app-settings.test.ts, which owns that code.2 test files, 464 gross lines, no source change.
Validation
At
f6dc8105c9, rebased on #3243 after it mergedmain:pnpm check:affected --runpasses (514 files, 4026 tests). Ten temporary mutations tosimctl-settings.tswere each caught by the plan tests; the source was then restored. The mutations covered the photos-add and deny→revoke mappings, toggle direction, reset-all fallback, mode rejection, refusal wordings, coordinate order, and error details.