Repository navigation
refactor(providers): unavailableFact for WebDriver and limrun, drop unused AWS options - #3303
Conversation
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 87e7be8. I found no problems in the code, and the evidence the change needs is in place. Not blocking: provider-limrun/src/facts-runtime.ts (https://github.com/callstack/agent-device/blob/87e7be8/packages/provider-limrun/src/facts-runtime.ts#L32) and deployment-runtime.ts still use hand-written {available:false,...} literals, so the limrun change covers only interaction-operations.ts; you can move them to unavailableFact here or later, or narrow the title, or leave it as is. The one failing check is the Integration Tests job, at test/integration/smoke-daemon-clean.test.ts:106. There, isProcessAlive(info.pid) returned true after a forced daemon retirement. That looks like an unrelated pid-reaping timing flake, because this diff touches only WebDriver and AWS fact code and limrun interaction facts, and the failing route (stopAndRetireDaemon) loads none of them. I did not re-run that test or run unit tests or typecheck myself, and the check:affected pass is from your report. No conflicts. Before merge, please re-run the Integration Tests job and land #3302 first, since this PR is stacked on it. |
…ailableFact Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
- build the inactive-session facts from the fully-unavailable table instead of restating thirty cells - remove AWS Device Farm options no caller supplies, and the LeaseValue helper that only served them Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Addressed at fc7915e (rebased on the current #3302 head): |
87e7be8 to
fc7915e
Compare
…rough unavailableFact Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fc7915e to
c754951
Compare
|
The PR is ready at c754951. The earlier review of 87e7be8 found it clean, and the new commit only changes how provider-limrun builds its constant refusal facts. The values stay the same. Not blocking: packages/provider-webdriver/src/runtime-deployment.ts:121 still returns two hand-built I did not run typecheck or the provider-limrun tests. I relied on your check:affected result at fc7915e and on reading the commit. Both Smoke Tests jobs are still queued, not failed. They drive local iOS and Android devices and never load the limrun provider, so this diff does not touch their route. The checks must finish green, and #3302 (the base) must merge first. |
… runtime and deployment facts Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Summary
Stacked on #3302. The WebDriver and limrun provider runtimes adopt
unavailableFactfor their refused operations, and two restated surfaces inprovider-webdrivergo away:createFullyUnavailablePlatformRuntimeFacts(inactiveSession)plus the onefoldoverride instead of thirty hand-listed cells;AwsDeviceFarmWebDriverRuntimeOptionsloses eight fields no caller supplies (clientVersion,region,webdriverCapabilities,configuration,deviceId,requestPolicy,prepareSession, and the lease-resolvedsessionName), along with theLeaseValuehelper that only served them. The type is not exported from the package.4 files, net −126 lines. No fact value or session capability changes.
Validation
Tested at 87e7be8:
pnpm check:affected --runpassed (format, lint, typecheck, related tests includingplatform-runtime.test.ts,aws-device-farm.test.ts,interaction-operations.test.ts). No device run applies.🤖 Generated with Claude Code