Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
9a804db to
aa8e691
Compare
|
This PR is ready at 1c517f3, and the code looks good. All 14 checks pass on this head, including the jobs behind check:layering, package boundaries and mutation ownership. I did not run those checks myself, so the identical layering output and the unchanged ownership and R75 counts rest on that green CI and your description. I also did not confirm that the old regex scanner never made edges from import-like text inside template literals in production sources. No conflicts. Not blocking: parseImports in scripts/layering/model.ts ignores parsed.errors, so a file OXC fails to parse would silently lose edges instead of failing the gate (typecheck makes this unreachable today), and the nine-pair test in scripts/layering/model.test.ts pins the live repository, so it breaks when one of those imports moves even if the parser is right. Take or leave both. The cubic-dev-ai thread on the importTypeSourceName qualifier is fixed at this head, so you can resolve it: #3317 (comment) This PR merges after its stacked base #3316 lands. |
1c517f3 to
65c5b40
Compare
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Addressed both broader review suggestions and rebased onto the corrected #3316 head. Final head:
Explicit production comparison against parent
Every new edge is a type dependency permitted by the existing rules; there are no new findings to suppress or repair. R6/R75 still inspect type edges under their existing semantics; eager closure/R4 use evaluated value edges, so their budgets do not grow. Ownership includes type edges but these do not add owners. The eight new pairs are runner-provider → runner-artifact; interaction/index → gesture-runtime and touch-runtime; interaction/internal/interaction → contracts/android-observation; snapshot-runtime-binding → contracts/focus-runtime, interactor-types and type-text-runtime; sdk/artifacts → platform-android/mechanics. Other added occurrences are type references between file pairs already represented by existing imports. The qualifier-symbol/R75 inline thread remains resolved. |
65c5b40 to
5f41117
Compare
|
Summary
TSImportTypeshare the existing OXC AST. Source-side qualifier symbols make named type dependencies visible to R75. Mixed type/dynamic edges stay distinct; malformed parses now fail closed.Validation
5f411172f460e2d16eabf97e94ca749f565ca554:pnpm check:affected --runpassed every runnable check;pnpm check:fallow --base origin/mainalso passed. CI pending.8ed2225f0: all 10,182 prior resolved edges retain identical symbols/kinds/lines/residue. No edges removed. Layering stdout, 22 cycle paths/kinds and all seven ownership sets (3,813 assignments) match exactly; R75 remains 13 shape / 22 authority files.