Repository navigation
test(daemon): pin that the first click after an unobservable iOS open taps the settled point - #3368
Merged
Merged
Conversation
… taps the settled point (#3354) Drives the real daemon open then selector click through the scripted iOS runner whose first read puts General at y=319 and the next two at y=406, and asserts the dispatched tap is the settled cell centre. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
This looks ready at 7ba8865. The new provider-scenario test pins that the first click after an unobservable iOS open taps the settled point, not the pre-shift one. The diff only adds the test and its world, so no production route changes and no live run is needed. Not blocking: All 19 checks pass, and there are no conflicts. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an end-to-end regression test for #3354. The existing test in #3356 only shows that the screen read settles. This one shows that the tap goes where the target settled.
The test runs the real daemon
open com.apple.Preferencesroute. It checks that the response reportstiming.postOpenObservation: "unobservable", then runsclick 'label="General"'. The scripted iOS runner servesGeneralat y=319, then at y=406 twice. The test asserts that the one tap the runner receives is at (201, 428), the centre of the settled cell.assertComplete()confirms that the click used all three reads, with no extra read before or after the tap.Test-only:
ios-world.tsgainscreateIosSettledClickWorld, andios-lifecycle.test.tsgains the test.Validation
markPostOpenStabilizationcall insession-open-execution.tsmakes the test fail. The tap goes to y=341, the centre of the stale cell, instead of y=428.pnpm check:affected --runpassed on7ba8865b6.🤖 Generated with Claude Code