Repository navigation
ci(ios): keep every step's request log in the Settings replay smoke - #3374
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
|
Thanks for the change. I reviewed 84623cc and found no code problems in the diff, but I can't call it ready yet because the PR doesn't show that The failing check is the Android Smoke Tests job, which fails on the helper-transport assertion expecting 'persistent-session'. It is likely unrelated, because this diff only touches the iOS Settings replay step in Not blocking: the same evidence would also confirm what |
|
Shown on this PR's own iOS run: 38062260581 at
This run's open also reported |
|
Thanks, that settles it for 84623cc. The iOS run 38062260581 passed at this commit, and the upload step collects |
|
Summary
Adds
--debugto the iOS Settings replay smoke on CI.Without it, a successful step's request log is never written to disk. In a failed
01-settings.adattempt, the artifacts keep only the failingwait's log. The click before it, whose tap went to the stale point, leaves no record of its pre-tap capture or its post-open settle. #3367 needs that record to tell "the layout moved after the capture" apart from "the capture read a layout still settling".With
--debug, every step's request log is kept in the uploadedios-artifacts. That includespost_gesture_snapshot_stabilizedandpost_gesture_snapshot_stabilization_timeout. Only this one replay step changes.Trade-off:
--debugalso streams the daemon log into the job output, so this step's console output gets longer.Refs #3367.
Validation
pnpm check:affected --runpassed.requests/folder (checked in run37815426076), so the extra logs will be uploaded with no other change.🤖 Generated with Claude Code