Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .oxfmtrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
"scripts/maestro-conformance/corpus/**",
"fallow-baselines/**",
// One entry per line, so each pinned runner request changes as one reviewable diff line.
"contracts/fixtures/runner-requests.json"
"contracts/fixtures/runner-requests.json",
// One captured node per line, so the real keyboard capture stays a compact reviewable table.
"packages/capture-kit/src/snapshot-chrome.fixtures.ts"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ extension SnapshotPresentation {
"Cell",
"CheckBox",
"CollectionView",
// The keyboard plane. The shared chrome classifier (`snapshot-chrome`) anchors keyboard
// detection on this container; dropping it re-parents every `Key` onto the app root, where no
// structural rule can tell a key from app content (#3469).
"Keyboard",
"Link",
"MenuItem",
"Picker",
Expand Down
165 changes: 165 additions & 0 deletions contracts/fixtures/ios-snapshot-engine-conformance.json
Original file line number Diff line number Diff line change
Expand Up @@ -1332,6 +1332,171 @@
}
]
}
},
{
"name": "keyboard plane and its key subtree survive interactive projection",
"swift": true,
"projection": "regular",
"interactiveOnly": true,
"depth": null,
"scope": null,
"foldPolicy": "cursor-projected",
"truncated": false,
"residue": [],
"nodes": [
{
"index": 0,
"type": "Application",
"label": "App",
"rect": { "x": 0, "y": 0, "width": 320, "height": 240 },
"enabled": true,
"hittable": false,
"depth": 0
},
{
"index": 1,
"type": "Button",
"label": "Continue",
"rect": { "x": 10, "y": 20, "width": 80, "height": 30 },
"enabled": true,
"hittable": true,
"depth": 1,
"parentIndex": 0
},
{
"index": 2,
"type": "Other",
"identifier": "inputView",
"rect": { "x": 0, "y": 120, "width": 320, "height": 120 },
"enabled": true,
"hittable": true,
"depth": 1,
"parentIndex": 0
},
{
"index": 3,
"type": "Keyboard",
"rect": { "x": 0, "y": 150, "width": 320, "height": 90 },
"enabled": true,
"hittable": true,
"depth": 2,
"parentIndex": 2
},
{
"index": 4,
"type": "Key",
"label": "q",
"rect": { "x": 4, "y": 157, "width": 29, "height": 40 },
"enabled": true,
"hittable": true,
"depth": 3,
"parentIndex": 3
},
{
"index": 5,
"type": "Key",
"label": "w",
"rect": { "x": 37, "y": 157, "width": 29, "height": 40 },
"enabled": true,
"hittable": true,
"depth": 3,
"parentIndex": 3
},
{
"index": 6,
"type": "Button",
"label": "Next keyboard",
"rect": { "x": 4, "y": 205, "width": 40, "height": 30 },
"enabled": true,
"hittable": true,
"depth": 2,
"parentIndex": 2
}
],
"expected": {
"outcome": "success",
"truncated": false,
"residue": [],
"nodes": [
{
"index": 0,
"type": "Application",
"label": "App",
"rect": { "x": 0, "y": 0, "width": 320, "height": 240 },
"depth": 0,
"parentIndex": null,
"hittable": false,
"hiddenContentAbove": false,
"hiddenContentBelow": false
},
{
"index": 1,
"type": "Button",
"label": "Continue",
"rect": { "x": 10, "y": 20, "width": 80, "height": 30 },
"depth": 1,
"parentIndex": 0,
"hittable": true,
"hiddenContentAbove": false,
"hiddenContentBelow": false
},
{
"index": 2,
"type": "Other",
"label": null,
"rect": { "x": 0, "y": 120, "width": 320, "height": 120 },
"depth": 1,
"parentIndex": 0,
"hittable": true,
"hiddenContentAbove": false,
"hiddenContentBelow": false
},
{
"index": 3,
"type": "Keyboard",
"label": null,
"rect": { "x": 0, "y": 150, "width": 320, "height": 90 },
"depth": 2,
"parentIndex": 2,
"hittable": true,
"hiddenContentAbove": false,
"hiddenContentBelow": false
},
{
"index": 4,
"type": "Key",
"label": "q",
"rect": { "x": 4, "y": 157, "width": 29, "height": 40 },
"depth": 3,
"parentIndex": 3,
"hittable": true,
"hiddenContentAbove": false,
"hiddenContentBelow": false
},
{
"index": 5,
"type": "Key",
"label": "w",
"rect": { "x": 37, "y": 157, "width": 29, "height": 40 },
"depth": 3,
"parentIndex": 3,
"hittable": true,
"hiddenContentAbove": false,
"hiddenContentBelow": false
},
{
"index": 6,
"type": "Button",
"label": "Next keyboard",
"rect": { "x": 4, "y": 205, "width": 40, "height": 30 },
"depth": 2,
"parentIndex": 2,
"hittable": true,
"hiddenContentAbove": false,
"hiddenContentBelow": false
}
]
}
}
]
}
4 changes: 4 additions & 0 deletions packages/capture-kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@
"types": "./src/snapshot-chrome.ts",
"default": "./src/snapshot-chrome.ts"
},
"./snapshot-chrome-fixtures": {
"types": "./src/snapshot-chrome.fixtures.ts",
"default": "./src/snapshot-chrome.fixtures.ts"
},
"./snapshot-desktop-projection": {
"types": "./src/snapshot-desktop-projection.ts",
"default": "./src/snapshot-desktop-projection.ts"
Expand Down
4 changes: 4 additions & 0 deletions packages/capture-kit/src/ios-snapshot-engine/projection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ const REGULAR_ELIGIBLE_TYPES = new Set([
'cell',
'checkbox',
'collectionview',
// The keyboard plane. The shared chrome classifier (`snapshot-chrome`) anchors keyboard
// detection on this container; dropping it re-parents every `Key` onto the app root, where no
// structural rule can tell a key from app content (#3469).
'keyboard',
'link',
'menuitem',
'picker',
Expand Down
Loading
Loading