Repository navigation
refactor(replay): colocate eight package tests and drop four unused exports - #3647
Merged
Merged
Conversation
Pure renames; each test keeps its content. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
session-journal's event-log-lines, event-log-window and event-request, and replay-port's session-test-infrastructure, are imported only by relative path inside their own package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
The code in 80c70af looks good to me. The change renames eight tests and drops four unused exports, with no behavior change, and I found no remaining references to a renamed test or a removed specifier. CI had not finished when I looked, so I cannot yet say whether Typecheck, Repo Guards and Coverage pass. I did not check that each new test name matches the module it covers, or whether any entry in fallow-baselines is keyed to a renamed test path. There are no conflicts. Next step: wait for Repo Guards, Typecheck & Package and Coverage to go green. |
Contributor
Size Report
Startup median (7 runs, lower is better):
|
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part of the test-export / colocation sweep (coordinator:
refactor/no-test-exports). Replay-package scope, first slice: names eight tests for the module they test, and drops four package exports no one imports. No fixture or test-kit work here.Commits
refactor(replay): name eight package tests for the module they test— eightgit mv, zero content change.chore(gates): drop package exports nothing imports—package.jsonexports only.git diff -M --stat a907a919a HEAD: all eight renames at 100% similarity,0 insertions, 0 deletions.Colocation (recomputed with a prefix-match scan over
packages/{replay-port,ad-replay,ad-script,replay-test,maestro,session-journal,daemon-contracts})Before 9 (maestro 6, ad-script 1, replay-port 1, session-journal 1, matches the coordinator's count). After 1.
backend-vocabulary.test.tsformat-backend-vocabulary.test.tsformat.tsrun-script.test.tsrun-script-execution.test.tsrun-script-execution.tsexport-label-projection.test.tsexport-flow-label-projection.test.tsexport-flow.tsfacade-failure-suggestions.test.tsfacade-execution-failure-suggestions.test.tsfacade-execution.ts(collectMaestroFailureSuggestions)runtime-port.test.tsruntime-port-commands.test.tsruntime-port-commands.ts(itscreateMaestroRuntimePortis a test-local wrapper aroundexecuteMaestroRuntimeCommand)runtime-port-gestures.test.tsruntime-port-commands-gestures.test.tsscroll-container-classification.test.tsruntime-port-geometry-scroll-container.test.tsruntime-port-geometry.ts(resolveMaestroScrollableGesture)session-replay-builtin-vars.test.tssession-replay-vars.test.tssession-replay-vars.tsLeft alone, reported:
session-journal/src/__tests__/journal-request-input.test.ts. It is a type-level test acrosssession-event-log,session-event-requestandsession-event-action-presentation(one union of every request-shaped parameter the package accepts). It is an integration test of the package surface; splitting it would break the single union it asserts, and a made-up module name would game the rule.Test-count parity (
vitest run <files> --reporter=json, passed / failed)Before =
a907a919aat the old paths, after = this head at the new paths. 100/0 before, 100/0 after.Selection: all eight sit under
packages/*/src/**/*.test.ts(unit-core include) and were collected by path; no config, baseline or gate manifest names any of the old paths (git grepclean);check:gate-manifestok.vi.mock: none of the eight usesvi.mock(the maestrovihits arevi.fn).Exports dropped (importer list was empty for each; relative imports inside the package are untouched)
./session-test-infrastructure./session-event-log-lines,./session-event-log-window,./session-event-requestNo new subpath, barrel or
export *anywhere. No other package's export count changes.Gates (on
80c70afe1)pnpm check:quick,check:layering,check:fallow,check:gate-manifest,pnpm format(repo-wide): clean.check:affected --run: 15477 tests pass, 1 fails —scripts/__tests__/eager-closure-budgets.test.ts > no APPROVED_OVER_CEILING row is stalenamespackages/daemon/src/index.ts. That is not from this change: the same file passes ona907a919aonly because the stale-row check is deferred when merge-base equals head, and the daemon single-entry PR (#3633) left that approval row stale. Daemon thread: remove that row.Sequencing
R83 and the colocation baseline are not on main yet, so there is nothing of mine to delete from them. This PR only shrinks what the seed will contain (9 → 1 colocation entries in these packages).
🤖 Generated with Claude Code