refactor(test-kit): move the dispatch-disclosure harness out of contracts

[thymikee]

What

The dispatch-disclosure harness is a cross-package test fixture: eleven driver tests across daemon, platform-android, platform-apple, platform-web, provider-webdriver and root each read the shared row table and assert they drive exactly the rows they own. It was published from @agent-device/contracts/dispatch-disclosure-fixtures; it now lives in @agent-device/test-kit as three named exports.

• Commit 1: pure git mv of dispatch-disclosure.fixtures.ts and dispatch-disclosure.test.ts from packages/contracts/src to packages/test-kit/src (contracts cannot import test-kit, so its table test moves with the harness). Content is unchanged; both files use ../../../ for the repo root, which is the same depth.
• Commit 2: the file's first test (discloseDispatch / discloseUnclassifiedDispatch behaviour) tests kernel/errors, so it becomes packages/kernel/src/errors-dispatch-disclosure.test.ts, verbatim; the two table tests stay in test-kit.
• Commit 3: the eleven drivers import the three names they use (assertDispatchDisclosureDriversMatchRows, DISPATCH_DISCLOSURE_TABLE_PATH, dispatchDisclosureRowsOwnedBy) from @agent-device/test-kit; platform-android, platform-apple, platform-web and provider-webdriver declare test-kit in devDependencies and tsconfig references (daemon already did); the contracts subpath and its export-snapshot line are removed.
• Commit 4: merges two duplicate test-kit import statements that lint flagged.
• Commit 5 (chore(gates)): R13 refused any @agent-device/test-kit import from a platform package, tests included. It now allows it in test files (*.test.ts, __tests__/, *.fixtures.*) only; production source is still refused. Unit-tested both ways in platform-package-policy.test.ts.

Fixture decision

Fixture	Importers by package	Outcome	Reason
contracts/dispatch-disclosure-fixtures	daemon 2 tests, platform-android 2, platform-apple 2, platform-web 1, provider-webdriver 2, root 2	case 3: test-kit	shared by driver tests of six packages; needs only kernel types and the repo-level table

Parity

vitest run <files> --reporter=json, origin/main against this branch:

	files	tests passed
before	12 (11 drivers + contracts dispatch-disclosure.test.ts, 3 tests)	196 / 196
after	13 (11 drivers + kernel errors-dispatch-disclosure 1 + test-kit dispatch-disclosure 2)	196 / 196

unit-core includes packages/*/src/**/*.test.ts, so the moved test-kit and kernel tests are selected; check:affected --run ran them. The 11 drivers were not moved (specifier only). Several use vi.mock; none of those mocks was edited, and all pass.

Surface and counts

exports: contracts 133 -> 132 (./dispatch-disclosure-fixtures removed); test-kit stays one "." entry with +3 named exports; no new subpaths, barrels or export *. New devDependency + tsconfig reference on test-kit in platform-android, platform-apple, platform-web, provider-webdriver (test-kit reaches only capture-kit, contracts, host-kit, kernel, so no cycle; tsc -b passes).

Colocation (my scan): contracts 1 -> 0 not beside a named module.

Gates

check:quick, check:layering, check:fallow, check:gate-manifest, pnpm format, check:affected --run: all pass on head.

🤖 Generated with Claude Code

[cubic-dev-ai]

All reported issues were addressed across 28 files

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic</sub>

[github-actions]

Size Report

Metric	Base	Current	Diff
Installed (including dependencies)	5.24 MB	5.24 MB	0 B
Package (unpacked)	5.24 MB	5.24 MB	0 B
Package (download)	1.58 MB	1.58 MB	-12 B

Startup median (7 runs, lower is better):

Scenario	Base	Current	Diff
CLI --version	29.1 ms	28.3 ms	-0.9 ms
CLI --help	81.9 ms	82.4 ms	+0.5 ms

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-16 06:03 UTC

[thymikee]

The move itself looks right at 1e9a0ab: test-kit owns the harness, kernel owns the error test, and contracts shrinks.

One layering rule needs a small change before merge. isTestKitTestImport decides "is test support" from path substrings. The same file already imports isProductionSourceFile, which owns that classification and also covers test/ trees, *.spec.*, fixtures.ts and *-fixtures.ts. A platform-package test-support file outside the listed substrings, such as a *.spec.ts, would get a false R13 refusal when it imports test-kit. No current file is hit, so this fails closed and does not break anything today. Could R13 state the rule once as specifier === '@agent-device/test-kit' && !isProductionSourceFile(file)? That matches the invariant R11 and R83 already use. I could not find a smaller shape: the harness cannot sit in kernel without mixing six packages' test paths into a production package, and keeping it in contracts is what R83 forbids.

Not blocking: after that change, platform-package-policy.test.ts could also cover a __tests__/ file and a .fixtures. file, since the new test only exercises probe.test.ts. You can take or leave it.

The open inline thread on this predicate still applies: #3690 (comment). It is the same issue as above. Its cited example, root src/recording/fixtures.ts, is outside platform packages and never reaches this branch, so the problem is latent only.

All 21 checks are still queued and none has failed, so I have no job output. I did not run check:layering, the unit tests or tsc -b, so the 196/196 parity and gate-pass claims are yours. No device validation is needed for a test-only move. There are no conflicts.

Before merge, replace isTestKitTestImport with !isProductionSourceFile(file), then get the layering, typecheck and unit jobs green on the new head.

[thymikee]

Addressed the review and the open thread: R13's test-kit exception now uses the shared isProductionSourceFile predicate instead of path substrings, with test cases for src/recording/fixtures.ts, .test, .spec and a refused production file (efec583).

[thymikee]

This PR is ready at efec583. The earlier thread on scripts/layering/platform-package-policy.ts:178 is fixed: isTestKitTestImport now calls isProductionSourceFile, and platform-package-policy.test.ts covers the fixtures.ts, .test, .spec and refused-production cases. CI is green (23 checks, none failing), and the layering gate and platform-package-policy.test.ts exercise the changed R13 path directly. There are no conflicts. I read the diff against the merge base and did not rerun layering or vitest locally. The unchanged parts of the move (fixtures content, kernel test split) were covered by the previous review and I did not recheck them.

Not blocking, and you can take or leave these: R13 reads every tracked .ts file, so a non-src/ tooling file in a platform package, such as packages/platform-apple/scripts/verify-installed-snapshot-bridge.ts, can import test-kit without a violation. The classifier docstring says this is on purpose. Also, commit 5 in the PR body still says the exception covers *.test.ts, __tests__/ and *.fixtures.*, while the code now delegates to isProductionSourceFile.

The earlier inline thread on the R13 classifier no longer applies, because the head fixes it, so you can resolve it: #3690

No further work is needed before merge, beyond maintainer approval.