Repository navigation
fix(apple): expose toolchain probe failures in smoke builds - #3973
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
This PR is ready at 2d667a9. I found no problems in the code. All checks at this commit pass, including the Smoke Tests job, whose log shows the new diag lines for iOS and macOS with healthy probes. There are no conflicts. Not blocking, and fine to take or leave: (1) no test asserts that the metadata script prints I did not re-run the 81 focused tests or the "fails on the previous head" check for the four regression cases. The earlier thread on probe failure reasons (#3973 (comment)) is fixed at this head, so you can resolve it. |
Summary
Recent iOS smoke failures affect main: run 40339024659 at
840f9c40e3compiled successfully, then exhausted the toolchain fingerprint budget before smoke scenarios ran.Record each probe's command, budget, duration, exit, normalized exception, and classified result failure. Enable diagnostics in the metadata writer and preserve its final typed error details. Three files changed; no scope expansion. Issue: none (directly requested investigation).
This fixes missing evidence, not the intermittent hosted stall. Timeout and retry policies remain unchanged.
Validation
2d667a9c2fe573a555c9418ec5d5e4db7fd723aa.pnpm check:affected --run --head HEAD: passed; 37 checks passed/25 skipped; 2,806 related tests passed.run-9nLp5I:status=passed,exactCommit=true, base581357bc72c65de9ba798e7299681b19a5c13af4.4f93aa233e: 4 failed/77 passed; current head: 81 passed. Initial diagnostic-loss regression also failed on unchanged main.