Repository navigation
refactor(ios): drop the unused vector rotation and the duplicate round trip - #3975
Merged
Merged
Conversation
…d trip `CoordinateSpaceRotation.native(vector:interfaceOrientation:)` has no caller outside its own test: gesture dispatch uses `native(point:in:interfaceOrientation:)` and capture uses `oriented(point:rect:...)`. Delete the overload and its test. Delete the runner's `testSynthesizedDispatchInvertsCaptureOnEveryInterfaceOrientation`. The host `CoordinateSpaceTests.testOrientationRotationRoundTripsBetweenInterfaceAndNativeSpace` already pins the same inverse identity over four orientations, an unknown orientation, and an iPad-sized offset frame. Mutating the `landscapeLeft` row of `oriented` now fails three host tests with the runner copy removed. Say what `.none` means: the resolved window's box sits at the screen origin, not that the app fills the screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
I found no problems in the code at 66bf202. The change touches only Swift runner unit tests, a snapshot-presentation package and a doc comment, so it does not overlap any daemon, CLI or smoke route. The Smoke Tests check is still running and has not failed, so the next step is for it to finish green. I did not run the Swift tests or the mutant experiment; this review relies on the runs reported in the PR and on static greps. |
thymikee
added
the
ready-for-human
Member
Author
|
Smoke Tests is green at 66bf202 (the first run failed on a |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes three pieces of the iPhone/iPad coordinate-space code that pin nothing. No behavior change, no scope expansion, no linked issue. Four files, 66 lines removed.
CoordinateSpaceRotation.native(vector:interfaceOrientation:)and its test. A repository-wide search finds no caller outsideCoordinateSpaceTests.swift; dispatch usesnative(point:in:)and capture usesoriented(point:rect:). Itspubliconly serves the runner target in this repo.RunnerTests+SynthesizedInteractionTests.testSynthesizedDispatchInvertsCaptureOnEveryInterfaceOrientation. HostCoordinateSpaceTests.testOrientationRotationRoundTripsBetweenInterfaceAndNativeSpacepins the same inverse identity over the same four orientations, plus unknown and an iPad-sized offset frame. Both maps are affine, so either round trip implies the other.TextEntryContentTranslation.nonemeans the resolved window's box sits at the screen origin, not that the app fills the screen.Validation
Head 66bf202, base 581357b.
oriented'slandscapeLeftrow readsheight - point.y.swift test --package-path apple/snapshot-presentation: base 24 tests 0 failures; candidate removed plus mutant 13 failures, led by the retained round-trip test. Worktree removed.pnpm gate ios-snapshot-differential: Swift 23 tests 0 failures; 12 TypeScript tests pass.RunnerTests+SynthesizedInteractionTestsmethods: iPhone 17 Pro Max 16 passed, iPad Air 11-inch (M4) 16 passed, 0 failures.pnpm check:affected --run --head 66bf202ae: passed,exactCommit=true.check:xctest-selection: 0 methods dark.Apple / Smoke Testsfailed once on an infrastructure fault in its log (hashFiles(...)timed out at 120 s, skipping the iOS XCTest step). Rerun once: passed. The sole-screen route is unchanged, so no XCTest Nightly dispatch.Size: installed and unpacked package -484 B, download -64 B; startup medians within noise.
🤖 Generated with Claude Code