Repository navigation
fix(android): record the instrumentation result when the snapshot helper exits without output #4021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
04310da
fix(android): record the instrumentation result when the snapshot hel…
thymikee 68f55a9
fix(android): satisfy lint for the instrumentation result diagnostics
thymikee 8f283da
fix(android): keep snapshot content out of the helper exit diagnostic…
thymikee 86d1133
fix(android): filter snapshot content before cutting the tail, and re…
thymikee 30f2f0d
fix(android): match only UiAutomator attributes as snapshot content a…
thymikee 9eddef3
chore(android): drop an unused export and share the signal field helper
thymikee 4057e42
refactor(android): keep only allowlisted instrumentation fields and a…
thymikee a61ecc1
test(android): cover stderr beyond the retained window
thymikee 8bcc0ae
refactor(android): split protocol record reading out of the stdout li…
thymikee 3db8275
fix(android): attach no raw helper stream on any failure path and fla…
thymikee 28678f4
test(android): narrow the rejected startup error before reading its d…
thymikee c35d186
fix(android): read instrumentation results for every parse failure an…
thymikee 77a7765
refactor(android): record parsed instrumentation fields only, drop th…
thymikee 4861da3
fix(android): keep the helper failure message and stderr detail as be…
thymikee 63ee8b5
fix(android): withhold message fields that hold snapshot markers and …
thymikee 2e62e97
fix(android): withhold message fields with a generic fail-closed rule
thymikee c97885f
fix(android): match entities generically and keep the abort message t…
thymikee 5e9942f
refactor(android): drop the dead numeric-entity branches from the mar…
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.