Skip to content

refactor: update portal class components to functional - #2226

Closed
unikvozm wants to merge 3 commits into
masterfrom
refactor/portal
Closed

refactor: update portal class components to functional#2226
unikvozm wants to merge 3 commits into
masterfrom
refactor/portal

Conversation

@unikvozm

@unikvozm unikvozm commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

Summary

Portal class components are rewritten as functional ones.

Test plan

@callstack-bot

callstack-bot commented Sep 11, 2020 •
edited
Loading

Copy link
Copy Markdown

Hey @unikvozm, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions

github-actions Bot commented Sep 11, 2020

Copy link
Copy Markdown

The mobile version of example app from this branch is ready! You can see it here

.

Trancever
Trancever suggested changes Sep 15, 2020
View reviewed changes
Comment thread src/components/Portal/Portal.tsx Resolved
Comment thread src/components/Portal/Portal.tsx Resolved
Comment thread src/components/Portal/PortalConsumer.tsx Resolved
@unikvozm
unikvozm requested a review from Trancever November 6, 2020 15:14
@github-actions

github-actions Bot commented Jan 6, 2021

Copy link
Copy Markdown

Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days.

@github-actions github-actions Bot added the Stale label Jan 6, 2021
@github-actions github-actions Bot closed this Jan 13, 2021
@Trancever Trancever reopened this Jan 13, 2021
@github-actions github-actions Bot closed this Jan 21, 2021
@unikvozm unikvozm reopened this Jan 21, 2021
@unikvozm unikvozm removed the Stale label Jan 21, 2021
@github-actions

github-actions Bot commented Mar 23, 2021

Copy link
Copy Markdown

Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days.

@github-actions github-actions Bot added the Stale label Mar 23, 2021
@ali-rantakari ali-rantakari mentioned this pull request Nov 26, 2021
Closed
@Doberjohn

Doberjohn commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

This targets the old master branch, which is no longer maintained, and on main Portal is already a function component that uses context, with the portal code reworked since (#5048, #5126). Closing it as obsolete. If you'd like to convert the remaining class components, a fresh PR against main is welcome.

@Doberjohn Doberjohn closed this Nov 4, 2026
@Doberjohn
Doberjohn deleted the refactor/portal branch November 4, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trancever Trancever Awaiting requested review from Trancever

Assignees

No one assigned

Labels

Keep opened

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@unikvozm @callstack-bot @Doberjohn @Trancever @brunohkbx